Re: [PATCH v3 weston] compositor-drm: Ignore non-KMS devices

2017-02-13 Thread Daniel Stone
Hi Emil, Thanks for the review! On 10 February 2017 at 19:51, Emil Velikov wrote: > On 10 February 2017 at 17:43, Daniel Stone wrote: >> +static bool >> +drm_device_is_kms(struct drm_backend *b, struct udev_device *device) >> +{ >> + [...] >> + >> + b->drm.fd = fd; >> + b->drm.

Re: [PATCH v3 weston] compositor-drm: Ignore non-KMS devices

2017-02-10 Thread Emil Velikov
Hi Daniel, Not a huge expert on this code, so take the following with a grain of salt. On 10 February 2017 at 17:43, Daniel Stone wrote: > Given that we can have render-only devices, or vgem in a class of its > own, ignore any non-KMS devices in compositor-drm's device selection. > For x86 platf

[PATCH v3 weston] compositor-drm: Ignore non-KMS devices

2017-02-10 Thread Daniel Stone
Given that we can have render-only devices, or vgem in a class of its own, ignore any non-KMS devices in compositor-drm's device selection. For x86 platforms, this is mostly a non-issue since we look at the udev boot_vga issue, but other architectures which lack this, and have multiple KMS devices