Re: [PATCH v3] xwm: Fix memory leak

2018-03-27 Thread Derek Foreman
On 2018-03-26 08:36 AM, Pekka Paalanen wrote: > On Fri, 23 Mar 2018 15:07:07 -0500 > Derek Foreman wrote: > >> On 2018-03-23 02:41 PM, Scott Moreau wrote: >>> A memory leak introduced by 6b58ea8c led to me finding a bigger leak, >>> which is xwm was calling frame_create() without calling frame_de

Re: [PATCH v3] xwm: Fix memory leak

2018-03-26 Thread Pekka Paalanen
On Fri, 23 Mar 2018 15:07:07 -0500 Derek Foreman wrote: > On 2018-03-23 02:41 PM, Scott Moreau wrote: > > A memory leak introduced by 6b58ea8c led to me finding a bigger leak, > > which is xwm was calling frame_create() without calling frame_destroy(). > > This meant that the associated icon_surf

Re: [PATCH v3] xwm: Fix memory leak

2018-03-23 Thread Derek Foreman
On 2018-03-23 02:41 PM, Scott Moreau wrote: > A memory leak introduced by 6b58ea8c led to me finding a bigger leak, > which is xwm was calling frame_create() without calling frame_destroy(). > This meant that the associated icon_surface was not being destroyed, > leaving the destroy handler for it

[PATCH v3] xwm: Fix memory leak

2018-03-23 Thread Scott Moreau
A memory leak introduced by 6b58ea8c led to me finding a bigger leak, which is xwm was calling frame_create() without calling frame_destroy(). This meant that the associated icon_surface was not being destroyed, leaving the destroy handler for it broken. Here we fix this by calling frame_destroy()