I will push new patch with minor fix to the strtol function in wayland and
move this old patch (after segfault fix) to weston so that it does not end
up in libwayland APIs.
Consequently I changed its property in patchwork
BR
imran
On Wed, Oct 29, 2014 at 10:27 AM, Imran Zaman wrote:
>
>
> On We
On Wed, Oct 29, 2014 at 10:09 AM, Giulio Camuffo
wrote:
> 2014-10-29 8:45 GMT+02:00 Imran Zaman :
> > Daniel!
> >
> > As per your logic, I see wl_list APIs exposed etc, which shouldn't be
> part
> > of libwayland as well.
> > similarly, wl_fixed_to_double and wl_array shouldn't be part of the
> w
2014-10-29 8:45 GMT+02:00 Imran Zaman :
> Daniel!
>
> As per your logic, I see wl_list APIs exposed etc, which shouldn't be part
> of libwayland as well.
> similarly, wl_fixed_to_double and wl_array shouldn't be part of the window
> system. Isnt it?
> I can make inline functions if that helps.
wl_
Daniel!
As per your logic, I see wl_list APIs exposed etc, which shouldn't be part
of libwayland as well.
similarly, wl_fixed_to_double and wl_array shouldn't be part of the window
system. Isnt it?
I can make inline functions if that helps.
Btw here is an API patch, which has not be reviewed till
Hi,
On 28 October 2014 15:40, Imran Zaman wrote:
> You guys should check the reason why the patch is there rather than
> throwing out random thoughts or blunt comments.
>
> I did this patch mainly because weston/wayland has been using
> strtol/strtoul functions in number of places with buggy err
You guys should check the reason why the patch is there rather than
throwing out random thoughts or blunt comments.
I did this patch mainly because weston/wayland has been using
strtol/strtoul functions in number of places with buggy error checks, and
duplicate code everywhere. Weston and wayland
Hi,
On 28 October 2014 11:21, Giulio Camuffo wrote:
> 2014-10-27 18:51 GMT+02:00 Jasper St. Pierre :
> > Can I also suggest that we don't make this public API? These are internal
> > helpers for libwayland, not designed for any consumers. We've been
> burned by
> > making too much internal helpe
2014-10-27 18:51 GMT+02:00 Jasper St. Pierre :
> Can I also suggest that we don't make this public API? These are internal
> helpers for libwayland, not designed for any consumers. We've been burned by
> making too much internal helper API public before.
+1
I don't think this belongs in the waylan
On 10/27/2014 09:51 AM, Jasper St. Pierre wrote:
+ if (!wl_strtol(since, NULL, 0, (long
*)&version))
This is baad. You cannot use the int version here, because in
wl_strol you write sizeof(long) on the address
of version and if sizeof(version)
Can I also suggest that we don't make this public API? These are internal
helpers for libwayland, not designed for any consumers. We've been burned
by making too much internal helper API public before.
On Mon, Oct 27, 2014 at 2:42 AM, Marek Chalupa wrote:
>
>
> On 22 October 2014 13:32, Imran Za
On 22 October 2014 13:32, Imran Zaman wrote:
> strtol/strtoul utility functions are used extensively in
> weston/wayland, and are not bug-free in their current form.
> To avoid definition in weston and wayland, its wrapped
> in functions with appropriate input and output checks.
> Test cases are
strtol/strtoul utility functions are used extensively in
weston/wayland, and are not bug-free in their current form.
To avoid definition in weston and wayland, its wrapped
in functions with appropriate input and output checks.
Test cases are also updated.
Signed-off-by: Imran Zaman
---
src/scann
12 matches
Mail list logo
