Re: [PATCH v3] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-24 Thread Kristian Høgsberg
On Wed, Jan 23, 2013 at 10:33:28AM +0200, Pekka Paalanen wrote: > Hi Philip, > > I still didn't test this, but it looks good. I have some minor comments > inline below. If we can address Pekkas comments below, I think we're ready to commit this. I second the nitpick about using $(NULL), we've no

Re: [PATCH v3] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-23 Thread David Herrmann
Hi Philip On Tue, Jan 22, 2013 at 9:59 PM, Philip Withnall wrote: > Here's the third version of the fbdev backend. This includes all the > fixes from the second version, plus a fix to use weston_launcher_open() > instead of open() for evdev devices, as pointed out by MoD. > > This patch is a squa

Re: [PATCH v3] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-23 Thread Pekka Paalanen
Hi Philip, I still didn't test this, but it looks good. I have some minor comments inline below. On Tue, 22 Jan 2013 20:59:44 + Philip Withnall wrote: > Here's the third version of the fbdev backend. This includes all the > fixes from the second version, plus a fix to use weston_launcher_o

[PATCH v3] fbdev: Add an fbdev compositor backend using pixman and evdev

2013-01-22 Thread Philip Withnall
Here's the third version of the fbdev backend. This includes all the fixes from the second version, plus a fix to use weston_launcher_open() instead of open() for evdev devices, as pointed out by MoD. This patch is a squashed and tidied up version of various commits on my branch: https://gitorious