Re: [PATCH v2 weston 2/7] compositor: do not flush shm buffer on destroy

2012-12-06 Thread Kristian Høgsberg
On Tue, Dec 04, 2012 at 03:58:11PM +0200, Pekka Paalanen wrote: > The protocol does not require us to flush_damage() on wl_buffer > destruction. In fact, by the time the server receives this request, the > client may have already clobbered the buffer's storage, so we could be > reading undefined da

[PATCH v2 weston 2/7] compositor: do not flush shm buffer on destroy

2012-12-04 Thread Pekka Paalanen
The protocol does not require us to flush_damage() on wl_buffer destruction. In fact, by the time the server receives this request, the client may have already clobbered the buffer's storage, so we could be reading undefined data. Instead, just forget about the buffer. The protocol already says, th