Hi,
On 2 February 2015 at 22:26, Hardening wrote:
> Le 02/02/2015 22:24, Derek Foreman a écrit :
>> On 02/02/15 01:40 PM, Bill Spitzak wrote:
>>> Is there a reason it does not just clear the pointer when
>>> keyboard_device_count is changed to zero? That would seem like a smaller
>>> patch.
>>
>>
On 02/02/15 04:26 PM, Hardening wrote:
> Le 02/02/2015 22:24, Derek Foreman a écrit :
>> Thanks for looking at this rather cumbersome patch! :)
>>
>> On 02/02/15 01:40 PM, Bill Spitzak wrote:
>>> Is there a reason it does not just clear the pointer when
>>> keyboard_device_count is changed to zero?
Le 02/02/2015 22:24, Derek Foreman a écrit :
> Thanks for looking at this rather cumbersome patch! :)
>
> On 02/02/15 01:40 PM, Bill Spitzak wrote:
>> Is there a reason it does not just clear the pointer when
>> keyboard_device_count is changed to zero? That would seem like a smaller
>> patch.
>
On 02/02/15 03:40 PM, Bill Spitzak wrote:
> On 02/02/2015 01:24 PM, Derek Foreman wrote:
>
>>> force_kill_binding() appears to have deleted the setting of the
>>> focus_surface variable.
>>
>> I don't see it... I think I just moved it to the top of the function?
>
> I think you are right.
>
> I
On 02/02/2015 01:24 PM, Derek Foreman wrote:
force_kill_binding() appears to have deleted the setting of the
focus_surface variable.
I don't see it... I think I just moved it to the top of the function?
I think you are right.
It is assuming keyboard is not null however.
___
Thanks for looking at this rather cumbersome patch! :)
On 02/02/15 01:40 PM, Bill Spitzak wrote:
> Is there a reason it does not just clear the pointer when
> keyboard_device_count is changed to zero? That would seem like a smaller
> patch.
Pulled Jonas Ådahl in on the CC for that question... I
Is there a reason it does not just clear the pointer when
keyboard_device_count is changed to zero? That would seem like a smaller
patch.
Assuming there is a good reason there seem to be some errors. At first I
thought there were just redundant checks for seat being null, which I
think should
Keyboards and pointers aren't freed when devices are removed,
so we should really be testing keyboard_device_count and
pointer_device_count in most cases, not the actual pointers.
Otherwise we end up with different behaviour after removing a
device than we had before it was inserted.
This commit r
