Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-12 Thread Bill Spitzak
Pekka Paalanen wrote: Ok, I'll rephrase what I really meant, just forgot to write a tiny subordinate clause in the above. When a fullscreen surface is raised topmost, it should be raised on top of panels. When some other surface is raised afterwards, the panels must be raised too, if the other

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-12 Thread Pekka Paalanen
On Wed, 11 Jan 2012 12:05:09 -0800 Bill Spitzak wrote: > Pekka Paalanen wrote: > > +#define WESTON_SURFACE_FULLSCREEN_NONE 0 > +#define WESTON_SURFACE_FULLSCREEN_SCALE 1 > +#define WESTON_SURFACE_FULLSCREEN_FORCE 2 > +#define WESTON_SURFACE_FULLSCREEN_FILL 3 > +#define W

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Bill Spitzak
Pekka Paalanen wrote: +#define WESTON_SURFACE_FULLSCREEN_NONE 0 +#define WESTON_SURFACE_FULLSCREEN_SCALE 1 +#define WESTON_SURFACE_FULLSCREEN_FORCE 2 +#define WESTON_SURFACE_FULLSCREEN_FILL 3 +#define WESTON_SURFACE_TYPE_CURSOR 0 +#define WESTON_SURFACE_TYPE_PANEL 1 +#define WESTON_SURFACE_TYPE_

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Juan Zhao
On Wed, 2012-01-11 at 11:50 +0200, Pekka Paalanen wrote: > > > What is this supposed to do? > > add the surface type for cursor/panel/general is to clarify the surface > > stack: > > -|--cursor > > -|--panel > > -|--general > > -|--general > > > > so that, we can figure out the window surfaces

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-11 Thread Pekka Paalanen
On Wed, 11 Jan 2012 15:01:37 +0800 Juan Zhao wrote: > Thanks very much for your review. > > On Tue, 2012-01-10 at 13:41 +0200, Pekka Paalanen wrote: > > > + struct wl_list *tlist=(struct wl_list *)ec->surface_list.next; > > > + int count=0; > > > + > > > + while((es->type != WESTON_S

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-10 Thread Juan Zhao
Thanks very much for your review. On Tue, 2012-01-10 at 13:41 +0200, Pekka Paalanen wrote: > > + struct wl_list *tlist=(struct wl_list *)ec->surface_list.next; > > + int count=0; > > + > > + while((es->type != WESTON_SURFACE_TYPE_GENERAL) && count > <1024){ > > + tlist=tlis

Re: [PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-10 Thread Pekka Paalanen
Hi, here a just some bits that caught my eye on a quick look, inline. We might prefer to have compositor and client changes in separate patches, after a minimal patch that fixes breakage from protocol changes. Should be easy to fix just the protocol bits and retain current behaviour, and then imp

[PATCH v2 1/2] shell & compositor: add parameters for set_fullsceen

2012-01-09 Thread juan . j . zhao
From: Alex Wu For some appliation(e.g. xbmc) wanting actual fullscreen effect, compositor should change the display mode to match the app UI rectangle. We add 2 parameters to set_fullscreen in order to let client to choose the appropriate way to deal with dismatch between the client's surface