Re: [PATCH v2 1/2] compositor: Propagate errors from module_init

2014-12-15 Thread Pekka Paalanen
On Tue, 09 Dec 2014 10:19:22 -0600 Derek Foreman wrote: > On 05/12/14 07:49 PM, Ondřej Majerech wrote: > > load_modules currently ignores errors signalled by both > > weston_load_module and module_init, and instead always returns 0. Its > > return value appears to be checked in callers, so we mos

Re: [PATCH v2 1/2] compositor: Propagate errors from module_init

2014-12-09 Thread Derek Foreman
On 09/12/14 12:29 PM, Ondřej Majerech wrote: > On Tue, 09 Dec 2014 10:19:22 -0600 > Derek Foreman wrote: > >> On 05/12/14 07:49 PM, Ondřej Majerech wrote: >>> load_modules currently ignores errors signalled by both >>> weston_load_module and module_init, and instead always returns 0. >>> Its retu

Re: [PATCH v2 1/2] compositor: Propagate errors from module_init

2014-12-09 Thread Ondřej Majerech
On Tue, 09 Dec 2014 10:19:22 -0600 Derek Foreman wrote: > On 05/12/14 07:49 PM, Ondřej Majerech wrote: > > load_modules currently ignores errors signalled by both > > weston_load_module and module_init, and instead always returns 0. > > Its return value appears to be checked in callers, so we mos

Re: [PATCH v2 1/2] compositor: Propagate errors from module_init

2014-12-09 Thread Derek Foreman
On 05/12/14 07:49 PM, Ondřej Majerech wrote: > load_modules currently ignores errors signalled by both > weston_load_module and module_init, and instead always returns 0. Its > return value appears to be checked in callers, so we most likely want to > propagate any errors. > > Signed-off-by: Ondře

[PATCH v2 1/2] compositor: Propagate errors from module_init

2014-12-05 Thread Ondřej Majerech
load_modules currently ignores errors signalled by both weston_load_module and module_init, and instead always returns 0. Its return value appears to be checked in callers, so we most likely want to propagate any errors. Signed-off-by: Ondřej Majerech --- src/compositor.c | 6 -- 1 file chan