Re: [PATCH v2] tests: fix bad-buffer-test

2014-04-16 Thread Kristian Høgsberg
On Sat, Apr 12, 2014 at 12:19:28PM +0300, Pekka Paalanen wrote: > On Fri, 11 Apr 2014 11:48:55 +0200 > Marek Chalupa wrote: > > > bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) > > make it pass. It shouldn't be so for example when assert() is invoked > > when a client co

Re: [PATCH v2] tests: fix bad-buffer-test

2014-04-12 Thread Pekka Paalanen
On Fri, 11 Apr 2014 11:48:55 +0200 Marek Chalupa wrote: > bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) > make it pass. It shouldn't be so for example when assert() is invoked > when a client couldn't connect to display. > > Make sure that only relevant asserts make th

Re: [PATCH v2] tests: fix bad-buffer-test

2014-04-11 Thread Bill Spitzak
It would be a lot simpler to only change the sighandler when you want it to fail, and reverse the type of test to be a success test? On 04/11/2014 02:48 AM, Marek Chalupa wrote: bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) make it pass. It shouldn't be so for example

[PATCH v2] tests: fix bad-buffer-test

2014-04-11 Thread Marek Chalupa
bad-buffer-test is FAIL_TEST and every assert() (or even SIGSEGV signal) make it pass. It shouldn't be so for example when assert() is invoked when a client couldn't connect to display. Make sure that only relevant asserts make the test pass and the other make it fail (by returning 0) --- tests/b