Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-10 Thread Pekka Paalanen
On Fri, 07 Nov 2014 14:25:07 -0800 Bill Spitzak wrote: > The bug is "client with keyboard focus does not have correct values for > currently-pressed keys if if the compositor consumes a key event". That is not a bug. That is the intended, correct behaviour. - pq __

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-07 Thread Bill Spitzak
You are right I was forgetting about the old discussion, and am getting confused as to where the bug is. IMHO the behavior when the client gets the focus currently is correct. However it is broken when the client already has the focus and the compositor gets a key. The patch you are proposing

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-07 Thread giuliocamuffo
Il ven nov 7 01:57:37 2014 GMT+0200, Bill Spitzak scrive: > > It may, but that's not the point. The key was eaten by the compositor > > binding, it must not be sent to the client. > > The key is not being "sent". A map of what keys are pushed down right > now is what is sent. > > The user cert

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-06 Thread Bill Spitzak
On 11/06/2014 11:55 AM, Giulio Camuffo wrote: 2014-11-06 21:48 GMT+02:00 Bill Spitzak : On 11/06/2014 09:55 AM, Giulio Camuffo wrote: weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also no

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-06 Thread Giulio Camuffo
2014-11-06 21:48 GMT+02:00 Bill Spitzak : > > > On 11/06/2014 09:55 AM, Giulio Camuffo wrote: >> >> weston key bindings are supposed to eat the key events, and not pass it >> on to clients, and indeed the wl_keyboard.key event is not sent. But >> we must also not put the key in the keys array to pa

Re: [PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-06 Thread Bill Spitzak
On 11/06/2014 09:55 AM, Giulio Camuffo wrote: weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else w

[PATCH v2] input: don't send to clients key events eaten by bindings

2014-11-06 Thread Giulio Camuffo
weston key bindings are supposed to eat the key events, and not pass it on to clients, and indeed the wl_keyboard.key event is not sent. But we must also not put the key in the keys array to pass to client with the wl_keyboard.enter event, or else we may send the 'eaten' one too. In the case of a k