Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread John Kåre Alsaker
Actually moving the GL and EGL state is done in a separate commit in the interest of clarity and reducing conflicts. This commit enables 3 EGL fields to be moved into gles2-renderer, of which only 1 field is required to move. I suggest one of the following options to continue: - Backport the movi

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread Kristian Høgsberg
On Fri, Oct 26, 2012 at 02:39:24PM -0400, Kristian Høgsberg wrote: > On Fri, Oct 26, 2012 at 06:06:15PM +0200, John Kåre Alsaker wrote: > > On Fri, Oct 26, 2012 at 3:59 PM, Kristian Høgsberg > > wrote: > > > On Thu, Oct 25, 2012 at 10:53:20PM +0200, John Kåre Alsaker wrote: > > >> This provides a

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread Kristian Høgsberg
On Fri, Oct 26, 2012 at 06:06:15PM +0200, John Kåre Alsaker wrote: > On Fri, Oct 26, 2012 at 3:59 PM, Kristian Høgsberg > wrote: > > On Thu, Oct 25, 2012 at 10:53:20PM +0200, John Kåre Alsaker wrote: > >> This provides an new API for gles2-renderer. It allows to move most EGL > >> initialization

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread John Kåre Alsaker
On Fri, Oct 26, 2012 at 3:59 PM, Kristian Høgsberg wrote: > On Thu, Oct 25, 2012 at 10:53:20PM +0200, John Kåre Alsaker wrote: >> This provides an new API for gles2-renderer. It allows to move most EGL >> initialization code and EGL surface creation into gles2-renderer, which >> makes compositor

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread Kristian Høgsberg
On Thu, Oct 25, 2012 at 10:53:20PM +0200, John Kåre Alsaker wrote: > This provides an new API for gles2-renderer. It allows to move most EGL > initialization code and EGL surface creation into gles2-renderer, which makes > compositor backends less dependent on gles2-renderer. As a side effect >

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread John Kåre Alsaker
On Fri, Oct 26, 2012 at 8:24 AM, Pekka Paalanen wrote: > Hi John! > > since this claims to provide a new API for gles2 renderer, I will > mainly comment on the API; its naming and semantics. > > > On Thu, 25 Oct 2012 22:53:20 +0200 > John Kåre Alsaker wrote: > >> This provides an new API for gles

Re: [PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-26 Thread Pekka Paalanen
Hi John! since this claims to provide a new API for gles2 renderer, I will mainly comment on the API; its naming and semantics. On Thu, 25 Oct 2012 22:53:20 +0200 John Kåre Alsaker wrote: > This provides an new API for gles2-renderer. It allows to move most EGL > initialization code and EGL s

[PATCH v2] gles2-renderer: Provide an API for backends to use.

2012-10-25 Thread John Kåre Alsaker
This provides an new API for gles2-renderer. It allows to move most EGL initialization code and EGL surface creation into gles2-renderer, which makes compositor backends less dependent on gles2-renderer. As a side effect weston_output gets a per-renderer state which gles2-renderer uses to store