Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-08 Thread Bryce Harrington
On Wed, Feb 08, 2017 at 11:33:29AM -0500, Micah Fedke wrote: > Bryce, > > Here is a branch that uses the legacy VIDIOC_QUERYCTRL to query the > controls, instead of VIDIOC_QUERY_EXT_CTRL. I believe this will make > it more compatible with older kernels. Can you test it? > > https://git.collabora

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-08 Thread Micah Fedke
Bryce, Here is a branch that uses the legacy VIDIOC_QUERYCTRL to query the controls, instead of VIDIOC_QUERY_EXT_CTRL. I believe this will make it more compatible with older kernels. Can you test it? https://git.collabora.com/cgit/user/fedke.m/weston.git/log/?h=yflip_queryctl_legacy_01 Tha

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-08 Thread Daniel Stone
Hi, On 8 February 2017 at 10:23, Pekka Paalanen wrote: > On Tue, 7 Feb 2017 17:17:41 -0800 > Bryce Harrington wrote: >> Breaks the build on older linux kernels. >> >> CC clients/weston_simple_dmabuf_v4l-simple-dmabuf-v4l.o >> clients/simple-dmabuf-v4l.c:358:25: warning: ‘struct v4l2_quer

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-08 Thread Pekka Paalanen
On Tue, 7 Feb 2017 17:17:41 -0800 Bryce Harrington wrote: > On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: > > On Mon, 6 Feb 2017 12:57:41 -0500 > > Micah Fedke wrote: > > > > > The v4l2 API can be queried to detect if the input video image is > > > horizontally or verticall

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Armin Krezović
If the required definitions are in UAPI headers, maybe you can just import the most recent header into weston source for the time being. IIRC, libevdev (used by libinput) does something similar in order to keep the build from breaking on older kernels. Maybe Peter can explain better. (Sent from we

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Derek Foreman
On 07/02/17 07:17 PM, Bryce Harrington wrote: On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: On Mon, 6 Feb 2017 12:57:41 -0500 Micah Fedke wrote: The v4l2 API can be queried to detect if the input video image is horizontally or vertically flipped. If the image is y-flipped,

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Bryce Harrington
On Tue, Feb 07, 2017 at 11:48:47AM +0200, Pekka Paalanen wrote: > On Mon, 6 Feb 2017 12:57:41 -0500 > Micah Fedke wrote: > > > The v4l2 API can be queried to detect if the input video image is > > horizontally or vertically flipped. If the image is y-flipped, we can > > set the ZWP_LINUX_BUFFER_

Re: [PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-07 Thread Pekka Paalanen
On Mon, 6 Feb 2017 12:57:41 -0500 Micah Fedke wrote: > The v4l2 API can be queried to detect if the input video image is > horizontally or vertically flipped. If the image is y-flipped, we can > set the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT flag to notify the > compositor. If the image is h

[PATCH v2] clients: teach simple-dmabuf-v4l to deal with flipped input

2017-02-06 Thread Micah Fedke
The v4l2 API can be queried to detect if the input video image is horizontally or vertically flipped. If the image is y-flipped, we can set the ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT flag to notify the compositor. If the image is h-flipped, we can only print a warning since linux_buffer_params_