Re: [PATCH v19 05/10] compositor-drm: Add test-only mode to state application

2018-07-11 Thread Daniel Stone
Hi, On Wed, 11 Jul 2018 at 11:20, Pekka Paalanen wrote: > On Tue, 10 Jul 2018 18:58:44 +0100 Daniel Stone wrote: > > @@ -2610,9 +2612,16 @@ drm_pending_state_apply_atomic(struct > > drm_pending_state *pending_state, > > case DRM_STATE_APPLY_ASYNC: > > flags |= DRM_MODE_PAGE_F

Re: [PATCH v19 05/10] compositor-drm: Add test-only mode to state application

2018-07-11 Thread Pekka Paalanen
On Tue, 10 Jul 2018 18:58:44 +0100 Daniel Stone wrote: > The atomic API can allow us to test state before we apply it, to see if > it will be valid. Use this when we construct a plane configuration, to > see if it has a chance of ever working. If not, we can fail > assign_planes early. > > This

Re: [PATCH v19 05/10] compositor-drm: Add test-only mode to state application

2018-07-11 Thread Daniel Stone
On Tue, 10 Jul 2018 at 18:59, Daniel Stone wrote: > @@ -3388,7 +3414,18 @@ drm_output_propose_state(struct weston_output > *output_base, > pixman_region32_fini(&renderer_region); > pixman_region32_fini(&occluded_region); > > + /* Check to see if this state will actually work

[PATCH v19 05/10] compositor-drm: Add test-only mode to state application

2018-07-10 Thread Daniel Stone
The atomic API can allow us to test state before we apply it, to see if it will be valid. Use this when we construct a plane configuration, to see if it has a chance of ever working. If not, we can fail assign_planes early. This will be used in later patches to incrementally build state by proposi