Re: [PATCH v16 03/23] compositor-drm: Make alpha-to-opaque handling common

2018-07-06 Thread Pekka Paalanen
On Thu, 5 Jul 2018 18:16:30 +0100 Daniel Stone wrote: > Rather than a hardcoded ARGB -> XRGB translation inside a > GBM-specific helper, just determine whether or not the view is opaque, > and use the generic helpers to implement the format translation. > > As a consequence of reorderin

[PATCH v16 03/23] compositor-drm: Make alpha-to-opaque handling common

2018-07-05 Thread Daniel Stone
Rather than a hardcoded ARGB -> XRGB translation inside a GBM-specific helper, just determine whether or not the view is opaque, and use the generic helpers to implement the format translation. As a consequence of reordering the calls in drm_output_prepare_overlay_view(), we move the GBM B