Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-07-10 Thread Pekka Paalanen
On Tue, 10 Jul 2018 08:53:54 +0100 Daniel Stone wrote: > Hi, > On Mon, 29 Jan 2018 at 10:55, Pekka Paalanen wrote: > > On Mon, 29 Jan 2018 09:17:49 + Daniel Stone > > wrote: > > > On 26 January 2018 at 14:04, Pekka Paalanen wrote: > > > > On Wed, 20 Dec 2017 12:26:52 + > > > > Dan

Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-07-10 Thread Daniel Stone
Hi, On Mon, 29 Jan 2018 at 10:55, Pekka Paalanen wrote: > On Mon, 29 Jan 2018 09:17:49 + Daniel Stone wrote: > > On 26 January 2018 at 14:04, Pekka Paalanen wrote: > > > On Wed, 20 Dec 2017 12:26:52 + > > > Daniel Stone wrote: > > >> +enum drm_output_propose_state_mode { > > >> + DR

Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-01-29 Thread Pekka Paalanen
On Mon, 29 Jan 2018 09:17:49 + Daniel Stone wrote: > Hi Pekka, > Thanks again for all the review! I'm really grateful you got this far, > and surprised: I'd expected the assign_planes() rewrite to be the much > more hairy part of the series, and state to be relatively > straightforward. \_o_/

Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-01-29 Thread Daniel Stone
Hi Pekka, Thanks again for all the review! I'm really grateful you got this far, and surprised: I'd expected the assign_planes() rewrite to be the much more hairy part of the series, and state to be relatively straightforward. \_o_/ Most everything I've seen going past I agree with at least on the

Re: [PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2018-01-26 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:52 + Daniel Stone wrote: > Add support for multiple modes: toggling whether or not the renderer > and/or planes are acceptable. This will be used to implement a smarter > plane-placement heuristic when we have support for testing output > states. > > Signed-off-by:

[PATCH v14 35/41] compositor-drm: Add modes to drm_output_propose_state

2017-12-20 Thread Daniel Stone
Add support for multiple modes: toggling whether or not the renderer and/or planes are acceptable. This will be used to implement a smarter plane-placement heuristic when we have support for testing output states. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 39 ++