Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Pekka Paalanen
On Tue, 16 Jan 2018 15:39:00 + Daniel Stone wrote: > Hi, > > On 16 January 2018 at 08:25, Pekka Paalanen wrote: > > On Wed, 20 Dec 2017 12:26:22 + > > Daniel Stone wrote: > >> + switch (type) { > >> + case WDRM_PLANE_TYPE_CURSOR: > >> + for

Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Daniel Stone
Hi, On 16 January 2018 at 08:25, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 12:26:22 + > Daniel Stone wrote: >> + switch (type) { >> + case WDRM_PLANE_TYPE_CURSOR: >> + format = GBM_FORMAT_ARGB; >> + break; >> +

Re: [PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2018-01-16 Thread Pekka Paalanen
On Wed, 20 Dec 2017 12:26:22 + Daniel Stone wrote: > Change the type of cursor_plane from a weston_plane (base tracking > structure) to a drm_plane (wrapper containing additional DRM-specific > details), and make it a dynamically-allocated pointer. > > Using the standard drm_plane allows us

[PATCH v14 05/41] compositor-drm: Use drm_plane for cursor plane

2017-12-20 Thread Daniel Stone
Change the type of cursor_plane from a weston_plane (base tracking structure) to a drm_plane (wrapper containing additional DRM-specific details), and make it a dynamically-allocated pointer. Using the standard drm_plane allows us to reuse code which already deals with drm_planes, e.g. a common cl