Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 04:44:51PM +0200, Jonas Ådahl wrote: > On Mon, Jul 30, 2018 at 10:35:49AM -0400, Simon Ser wrote: > > On July 30, 2018 3:14 PM, Dorota Czaplejewicz > > wrote: > > > From: Carlos Garnacho > > > > > > This new protocol description is an evolution of v2. > > > > > > - All pr

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 10:35:49AM -0400, Simon Ser wrote: > On July 30, 2018 3:14 PM, Dorota Czaplejewicz > wrote: > > From: Carlos Garnacho > > > > This new protocol description is an evolution of v2. > > > > - All pre-edit text styling is gone. > > - Pre-edit cursor can span characters. > > -

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Simon Ser
On July 30, 2018 3:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (OSK) state nor covered rectangle. > Compo

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Jonas Ådahl
On Mon, Jul 30, 2018 at 04:24:00PM +0200, Carlos Garnacho wrote: > Hey, > > With the serial number behavior cleared out, this all reads great to > me. Can't be part and judge though :), so no R-b label. I'll put my R-b stamp on it; I think we're good to go now! Jonas > > Cheers, > Carlos >

Re: [PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Carlos Garnacho
Hey, With the serial number behavior cleared out, this all reads great to me. Can't be part and judge though :), so no R-b label. Cheers, Carlos On Mon, Jul 30, 2018 at 4:14 PM, Dorota Czaplejewicz wrote: > From: Carlos Garnacho > > This new protocol description is an evolution of v2. > > -

[PATCH v10 wayland_protocols] text-input: Add v3 of the text-input protocol

2018-07-30 Thread Dorota Czaplejewicz
From: Carlos Garnacho This new protocol description is an evolution of v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations where the keyboard focus