Hi Bill
On Thu, Oct 4, 2012 at 6:46 PM, Bill Spitzak wrote:
>
>
> David Herrmann wrote:
>>
>> Hi Bill
>>
>> On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote:
>>>
>>> David Herrmann wrote:
>>>
> So since makekeys is ugly and gperf is a bit excessive, maybe we should
> just keep it simpl
David Herrmann wrote:
Hi Bill
On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote:
David Herrmann wrote:
So since makekeys is ugly and gperf is a bit excessive, maybe we should
just keep it simple, what do you think?
Works all very nice here! Thanks, I am all in favor of this approach.
Re
Hi Bill
On Thu, Oct 4, 2012 at 6:40 PM, Bill Spitzak wrote:
> David Herrmann wrote:
>
>>> So since makekeys is ugly and gperf is a bit excessive, maybe we should
>>> just keep it simple, what do you think?
>>
>>
>> Works all very nice here! Thanks, I am all in favor of this approach.
>> Reviewed-
David Herrmann wrote:
So since makekeys is ugly and gperf is a bit excessive, maybe we should
just keep it simple, what do you think?
Works all very nice here! Thanks, I am all in favor of this approach.
Reviewed-by: David Herrmann
No need to resend for the small fixes I suggested, though.
I
On Thu, Oct 04, 2012 at 04:58:50PM +0200, David Herrmann wrote:
> Hi Ran
>
> On Wed, Oct 3, 2012 at 10:18 AM, Ran Benita wrote:
>
> [snip]
>
> > So since makekeys is ugly and gperf is a bit excessive, maybe we should
> > just keep it simple, what do you think?
>
> Indeed. Thanks a lot for revi
And one minor style-fix below:
On Thu, Oct 4, 2012 at 4:58 PM, David Herrmann
wrote:
>> #include "xkbcommon/xkbcommon.h"
>> #include "utils.h"
>> -#include "ks_tables.h"
>> #include "keysym.h"
>> +#include "ks_tables.h"
>> +
>> +static int compare_by_keysym(const void *a, const void *b)
>> +{
Hi Ran
On Wed, Oct 3, 2012 at 10:18 AM, Ran Benita wrote:
[snip]
> So since makekeys is ugly and gperf is a bit excessive, maybe we should
> just keep it simple, what do you think?
Indeed. Thanks a lot for reviewing though. Just some comments on your
patch below:
> From 8fb5efb045b7207b010c97
Hi David,
On Tue, Oct 02, 2012 at 07:51:53PM +0200, David Herrmann wrote:
> Instead of using a home-brew hashtable generator, we should instead use
> the gperf program which is known to work.
>
> This removes the "makekeys" programs and instead replaces it by a file
> that can generate input file
Instead of using a home-brew hashtable generator, we should instead use
the gperf program which is known to work.
This removes the "makekeys" programs and instead replaces it by a file
that can generate input files for gperf. Gperf then generates hashtables
for all of these input files and writes
