Re: [PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-22 Thread Bill Spitzak
On 09/15/2014 04:58 AM, Ran Benita wrote: On Mon, Sep 15, 2014 at 08:21:34AM +0200, David Herrmann wrote: Why don't we require a keymap in xkb_compose_state_new()? Should be easy to do and we can then track modifiers reliably. Ok, a keysym which is a modifier in one keymap should never be a

Re: [PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 1:58 PM, Ran Benita wrote: > On Mon, Sep 15, 2014 at 08:21:34AM +0200, David Herrmann wrote: >> Why don't we require a keymap in xkb_compose_state_new()? Should be >> easy to do and we can then track modifiers reliably. >> Ok, a keysym which is a modifier in one keymap

Re: [PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-15 Thread Ran Benita
On Mon, Sep 15, 2014 at 08:21:34AM +0200, David Herrmann wrote: > Hi > > On Sun, Sep 14, 2014 at 11:05 PM, Ran Benita wrote: > > Signed-off-by: Ran Benita > > --- > > [snip] > > > diff --git a/src/compose/state.c b/src/compose/state.c > > new file mode 100644 > > index 000..06e4ce5 > > ---

Re: [PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-14 Thread David Herrmann
Hi On Sun, Sep 14, 2014 at 11:05 PM, Ran Benita wrote: > Signed-off-by: Ran Benita > --- [snip] > diff --git a/src/compose/state.c b/src/compose/state.c > new file mode 100644 > index 000..06e4ce5 > --- /dev/null > +++ b/src/compose/state.c > @@ -0,0 +1,196 @@ > +/* > + * Copyright © 2013

[PATCH libxkbcommon 2/4] compose: add xkbcommon-compose - implementation

2014-09-14 Thread Ran Benita
Signed-off-by: Ran Benita --- Makefile.am | 9 + configure.ac | 9 + src/compose/parser.c | 625 +++ src/compose/parser.h | 36 +++ src/compose/paths.c | 204 + src/compose/paths.h | 42 src/compose/stat