Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread Ran Benita
On Tue, Oct 02, 2012 at 11:07:11AM +0200, David Herrmann wrote: > On Tue, Oct 2, 2012 at 9:37 AM, Ran Benita wrote: > > I like the idea, and it seems to work. > > > > First, one thing that's easy to miss, this should work: > > assert(test_string("xf86_switch_vt_5", XKB_KEY_XF86Switch_VT_5)); >

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread David Herrmann
Hi Ran On Tue, Oct 2, 2012 at 9:37 AM, Ran Benita wrote: > Hi David, > > On Mon, Oct 01, 2012 at 07:29:58PM +0200, David Herrmann wrote: >> xkb_keysym_from_name() uses a big lookup table generated by "makekeys" >> to find keysyms. It does this case-sensitive because we have keys like >> XKB_KEY_A

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-02 Thread Ran Benita
Hi David, On Mon, Oct 01, 2012 at 07:29:58PM +0200, David Herrmann wrote: > xkb_keysym_from_name() uses a big lookup table generated by "makekeys" > to find keysyms. It does this case-sensitive because we have keys like > XKB_KEY_A and XKB_KEY_a. So if a user searches for "a" we must always > retu

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread Bill Spitzak
David Herrmann wrote: Hi Bill Could you please avoid top-posting? It's so much easier to read comments if they are _below_ the quoted text. Okay, I see that this is more like a compile-time operation, not run time. In that case I don't see a problem with case independence since it is just m

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread David Herrmann
Hi Bill Could you please avoid top-posting? It's so much easier to read comments if they are _below_ the quoted text. On Mon, Oct 1, 2012 at 9:11 PM, Bill Spitzak wrote: > I think you are asking for trouble here. > > The biggest problem I see is that you are calling tolower() which changes > dep

Re: [PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread Bill Spitzak
I think you are asking for trouble here. The biggest problem I see is that you are calling tolower() which changes depending on the locale. Though most software fixes this by forcing the locale to C, I'm not sure if that is acceptable for xkb. Please do not rely on anything more complicated th

[PATCH libxkbcommon 1/2] makekeys: add all symbols converted to lower-case

2012-10-01 Thread David Herrmann
xkb_keysym_from_name() uses a big lookup table generated by "makekeys" to find keysyms. It does this case-sensitive because we have keys like XKB_KEY_A and XKB_KEY_a. So if a user searches for "a" we must always return the case-sensitive match, which is XKB_KEY_a. However, lets look at XKB_KEY_XF86