Re: [PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-07 Thread Peter Hutterer
On Tue, Jun 07, 2016 at 06:33:19PM -0700, Jason Gerecke wrote: > On Sun, Jun 5, 2016 at 11:50 PM, Peter Hutterer > wrote: > > Move mode control to libinput. This reduces some flexibility on what we can > > do > > with modes but makes it a lot easier for anyone to implement modes correctly > > and

Re: [PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-07 Thread Jason Gerecke
On Sun, Jun 5, 2016 at 11:50 PM, Peter Hutterer wrote: > Move mode control to libinput. This reduces some flexibility on what we can do > with modes but makes it a lot easier for anyone to implement modes correctly > and have the LEDs apply appropriately, etc. Let's go with the option to make > th

Re: [PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-06 Thread Yong Bakos
Hi Peter, One possible documentation error, one minor nit, and a string error (see "TABLET_PAD_MODE") inline below. Otherwise, this is, uh, Proofread-by: Yong Bakos Regards, yong > On Jun 6, 2016, at 1:50 AM, Peter Hutterer wrote: > > Move mode control to libinput. This reduces some flexibil

[PATCH libinput 5/7] pad: Add a new API for modes and mode groups

2016-06-05 Thread Peter Hutterer
Move mode control to libinput. This reduces some flexibility on what we can do with modes but makes it a lot easier for anyone to implement modes correctly and have the LEDs apply appropriately, etc. Let's go with the option to make the 95% use-case easy. Note: whether the mode is actually used is