Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-11 Thread Bill Spitzak
On 08/10/2014 10:39 PM, Peter Hutterer wrote: On Sun, Aug 10, 2014 at 12:27:07PM +0200, Jonas Ådahl wrote: We could also drop the mask and generate 'pressed' events when adding a device; can we do that reliably without risking a race condition? technically yes, but I'm not sure it is a good

Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-10 Thread Peter Hutterer
On Sun, Aug 10, 2014 at 12:27:07PM +0200, Jonas Ådahl wrote: > On Mon, Aug 04, 2014 at 03:23:32PM +1000, Peter Hutterer wrote: > > On Sun, Jul 27, 2014 at 11:28:30PM +0200, Jonas Ådahl wrote: > > > When removing a device, its not guaranteed that all button or key > > > presses have been released, r

Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-10 Thread Jonas Ådahl
On Mon, Aug 04, 2014 at 03:23:32PM +1000, Peter Hutterer wrote: > On Sun, Jul 27, 2014 at 11:28:30PM +0200, Jonas Ådahl wrote: > > When removing a device, its not guaranteed that all button or key > > presses have been released, resulting in an invalid seat wide button > > count. > > > > Note that

Re: [PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-08-03 Thread Peter Hutterer
On Sun, Jul 27, 2014 at 11:28:30PM +0200, Jonas Ådahl wrote: > When removing a device, its not guaranteed that all button or key > presses have been released, resulting in an invalid seat wide button > count. > > Note that kernel devices normally will send release events when being > unplugged, bu

[PATCH libinput 3/4] evdev: Release still pressed keys/buttons when removing device

2014-07-27 Thread Jonas Ådahl
When removing a device, its not guaranteed that all button or key presses have been released, resulting in an invalid seat wide button count. Note that kernel devices normally will send release events when being unplugged, but this won't happen when removing a device from the path backend. Signed