Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-26 Thread Peter Hutterer
On 26/05/2014 16:33 , Hans de Goede wrote: Hi, On 05/25/2014 02:13 PM, Jonas Ådahl wrote: On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: Setting tp->scroll.direction = 0 before checking tp->scroll.direction to see if we need to send stop scroll events for vert / horz scrolling

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-25 Thread Hans de Goede
Hi, On 05/25/2014 02:13 PM, Jonas Ådahl wrote: > On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: >> Setting tp->scroll.direction = 0 before checking tp->scroll.direction >> to see if we need to send stop scroll events for vert / horz scrolling does >> not really work well. >> >> Als

Re: [PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-25 Thread Jonas Ådahl
On Fri, May 23, 2014 at 04:06:23PM +0200, Hans de Goede wrote: > Setting tp->scroll.direction = 0 before checking tp->scroll.direction > to see if we need to send stop scroll events for vert / horz scrolling does > not really work well. > > Also we need to check direction with an axis mask, not th

[PATCH libinput 2/6] touchpad: Fix sending of scroll stop events

2014-05-23 Thread Hans de Goede
Setting tp->scroll.direction = 0 before checking tp->scroll.direction to see if we need to send stop scroll events for vert / horz scrolling does not really work well. Also we need to check direction with an axis mask, not the axis number. While at it also add a tp_stop_scroll_events() helper fun