Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 03:17:36PM -0800, Bill Spitzak wrote: > I got the impression the ratelimit object was intended to be a single static > instance, not per-device. The idea is that if there is a burst of these at > once they are all from the same device, or due to some interaction between > th

Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Peter Hutterer
On Tue, Nov 04, 2014 at 09:35:38AM +0100, David Herrmann wrote: > Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we > will still receive SYN_DROPPED log-messages after multiple days of > runtime, even though there might have been a SYN_DROPPED flood at one > point in time.

Re: [PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread Bill Spitzak
I got the impression the ratelimit object was intended to be a single static instance, not per-device. The idea is that if there is a burst of these at once they are all from the same device, or due to some interaction between them, so you want to limit it all. Also it prevents an implementatio

[PATCH libinput 2/2] evdev: ratelimit SYN_DROPPED logging

2014-11-04 Thread David Herrmann
Use the ratelimit helpers for SYN_DROPPED logging. This guarantees that we will still receive SYN_DROPPED log-messages after multiple days of runtime, even though there might have been a SYN_DROPPED flood at one point in time. Signed-off-by: David Herrmann --- src/evdev.c | 14 +++--- sr