Re: [PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-02-10 Thread Hans de Goede
Hi, On 09-02-17 23:55, Peter Hutterer wrote: On Thu, Feb 09, 2017 at 05:25:36PM +0100, Hans de Goede wrote: Hi, First of all patches 1-9 and 11 looks good to me and are: Reviewed-by: Hans de Goede thx, fwiw, I already pushed these, so fixups will come as a separate patch. I've some remar

Re: [PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-02-09 Thread Peter Hutterer
On Thu, Feb 09, 2017 at 05:25:36PM +0100, Hans de Goede wrote: > Hi, > > First of all patches 1-9 and 11 looks good to me and are: > > Reviewed-by: Hans de Goede thx, fwiw, I already pushed these, so fixups will come as a separate patch. > I've some remarks inline on this one. > > On 30-01-17

Re: [PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-02-09 Thread Hans de Goede
Hi, First of all patches 1-9 and 11 looks good to me and are: Reviewed-by: Hans de Goede I've some remarks inline on this one. On 30-01-17 01:58, Peter Hutterer wrote: Don't rely on BTN_TOUCH for "finger down", the value for that is hardcoded in the kernel and not always suitable. Some devic

[PATCH libinput 10/11] touchpad: use pressure values for touch is-down decision

2017-01-29 Thread Peter Hutterer
Don't rely on BTN_TOUCH for "finger down", the value for that is hardcoded in the kernel and not always suitable. Some devices need a different value to avoid reacting to accidental touches or hovering fingers. Implement a basic Schmitt trigger, same as we have in the synaptics driver. We also tak