Re: [PATCH libinput 1/6] evdev: add evdev_pointer_notify_physical_button

2015-04-15 Thread Hans de Goede
Hi, For some reason some of the patches have not made it to my mailbox, so I'm reviewing the entire set here, partially from the web archive. Patches 1 and 2 looks good and are: Reviewed-by: Hans de Goede The state machine code in patch 3 has some issues: In evdev_middlebutton_ldown_handle_e

[PATCH libinput 1/6] evdev: add evdev_pointer_notify_physical_button

2015-04-14 Thread Peter Hutterer
No functional changes at this point, this merely splits up any physical buttons (i.e. that represent buttons that exist on that device) vs. other buttons that are emulated in some way or another. This is in preparation for the addition of middle button emulation. Signed-off-by: Peter Hutterer --