Re: [PATCH libinput 1/2] udev: fix ALPS firmware detection

2016-02-09 Thread Peter Hutterer
On Tue, Feb 09, 2016 at 11:49:33AM +0100, Emilio Pozuelo Monfort wrote: > On 09/02/16 03:12, Peter Hutterer wrote: > > The firmware version is in id.version, not id.model which is always > > PSMOUSE_ALPS for ALPS devices. > > > > The various fw versions are listed in /drivers/input/mouse/alps.h >

Re: [PATCH libinput 1/2] udev: fix ALPS firmware detection

2016-02-09 Thread Emilio Pozuelo Monfort
On 09/02/16 03:12, Peter Hutterer wrote: > The firmware version is in id.version, not id.model which is always > PSMOUSE_ALPS for ALPS devices. > > The various fw versions are listed in /drivers/input/mouse/alps.h and > are all hex numbers. Version 8 is actually 0x800, change the match > according

Re: [PATCH libinput 1/2] udev: fix ALPS firmware detection

2016-02-09 Thread Hans de Goede
Hi, On 09-02-16 03:12, Peter Hutterer wrote: The firmware version is in id.version, not id.model which is always PSMOUSE_ALPS for ALPS devices. The various fw versions are listed in /drivers/input/mouse/alps.h and are all hex numbers. Version 8 is actually 0x800, change the match accordingly.

[PATCH libinput 1/2] udev: fix ALPS firmware detection

2016-02-08 Thread Peter Hutterer
The firmware version is in id.version, not id.model which is always PSMOUSE_ALPS for ALPS devices. The various fw versions are listed in /drivers/input/mouse/alps.h and are all hex numbers. Version 8 is actually 0x800, change the match accordingly. Expected side-effect: earlier versions of ALPS t