Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-20 Thread Vicente Bergas
On Monday, November 20, 2017 3:54:44 AM CET, Peter Hutterer wrote: On Sun, Nov 19, 2017 at 08:45:16PM +0100, Vicente Bergas wrote: On Thursday, November 16, 2017 2:29:05 AM CET, Peter Hutterer wrote: On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: ... Hi Peter, ba9e6012a52b pr

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-19 Thread Peter Hutterer
On Sun, Nov 19, 2017 at 08:45:16PM +0100, Vicente Bergas wrote: > On Thursday, November 16, 2017 2:29:05 AM CET, Peter Hutterer wrote: > > On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: > > > On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer > > > wrote: > > > > ... I'd appreciate i

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-19 Thread Vicente Bergas
On Thursday, November 16, 2017 2:29:05 AM CET, Peter Hutterer wrote: On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer wrote: ... I'd appreciate it if you could give it a test though. Cheers, Peter Hi Peter, just tested 4aa25b

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-15 Thread Peter Hutterer
On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote: > On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer > wrote: > > ... I'd appreciate it if you could give it a test > > though. > > > > Cheers, > >Peter > > Hi Peter, > just tested 4aa25b9de96321d946ed399b614d52deadf74403 (tip of yo

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-15 Thread Vicente Bergas
On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer wrote: > ... I'd appreciate it if you could give it a test > though. > > Cheers, >Peter Hi Peter, just tested 4aa25b9de96321d946ed399b614d52deadf74403 (tip of your debouncing branch on github), it failed on the very first click: [ 1910.895] (EE

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-14 Thread Peter Hutterer
On Tue, Nov 14, 2017 at 07:40:08PM +0100, Vicente Bergas wrote: > Hi Peter, > > (sorry, sent twice, first time I forgot to "reply-all") > > On Tue, Nov 14, 2017 at 5:22 AM, Peter Hutterer > wrote: > > ... > > >> -#define DEBOUNCE_TIME ms2us(12) > >> +#define DEBOUNCE_TIME ms2us(25) >

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-14 Thread Vicente Bergas
Hi Peter, (sorry, sent twice, first time I forgot to "reply-all") On Tue, Nov 14, 2017 at 5:22 AM, Peter Hutterer wrote: > ... >> -#define DEBOUNCE_TIME ms2us(12) >> +#define DEBOUNCE_TIME ms2us(25) > > 25ms is quite risky for the original algorithm, it's possible to > press/release e

Re: [PATCH libinput 1/1] Fix debouncing algorithm

2017-11-13 Thread Peter Hutterer
disclaimer: I was halfway through this, started fixing some comments myself and got stuck in "this is too complicated" land. See https://lists.freedesktop.org/archives/wayland-devel/2017-November/035782.html for the most recent set of patches. On Thu, Nov 02, 2017 at 12:34:02AM +0100, Vicente Be

[PATCH libinput 1/1] Fix debouncing algorithm

2017-11-01 Thread Vicente Bergas
Bouncing can occur when a button toggles, both press and release, and can bounce multiple times for each toggling. The algorithm has two states: cancel_noise==false and cancel_noise==true. When not canceling noise, the default state, any event received is inmediately committed and state is changed