Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-06 Thread Hans de Goede
Hi, On 06/04/2014 10:57 PM, Jonas Ådahl wrote: > On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: >> Hi, >> >> On 06/03/2014 07:34 AM, Peter Hutterer wrote: >>> Now that we have run-time changes of the tap.enabled state move the check >>> to the IDLE state only. Otherwise the tap mac

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 10:57:36PM +0200, Jonas Ådahl wrote: > On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: > > On 06/03/2014 07:34 AM, Peter Hutterer wrote: [...] > > > @@ -583,9 +580,56 @@ tp_tap_handle_timeout(struct tp_dispatch *tp, > > > uint64_t time) > > > return tp->t

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: > Hi, > > On 06/03/2014 07:34 AM, Peter Hutterer wrote: > > Now that we have run-time changes of the tap.enabled state move the check > > to the IDLE state only. Otherwise the tap machine may hang if tapping is > > disabled while a ges

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: > Now that we have run-time changes of the tap.enabled state move the check > to the IDLE state only. Otherwise the tap machine may hang if tapping is > disabled while a gesture is in progress. > > Two basic tests are added to check for the tap de

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 08:00:17AM +1000, Peter Hutterer wrote: > On Tue, Jun 03, 2014 at 10:42:50PM +0200, Jonas Ådahl wrote: > > On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > > > Now that we have run-time changes of the tap.enabled state move the check > > > to the IDLE state

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 10:42:50PM +0200, Jonas Ådahl wrote: > On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > > Now that we have run-time changes of the tap.enabled state move the check > > to the IDLE state only. Otherwise the tap machine may hang if tapping is > > disabled whil

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Jasper St. Pierre
On Tue, Jun 3, 2014 at 4:42 PM, Jonas Ådahl wrote: > On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > > Now that we have run-time changes of the tap.enabled state move the check > > to the IDLE state only. Otherwise the tap machine may hang if tapping is > > disabled while a gest

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: > Now that we have run-time changes of the tap.enabled state move the check > to the IDLE state only. Otherwise the tap machine may hang if tapping is > disabled while a gesture is in progress. > > Two basic tests are added to check f

[PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-02 Thread Peter Hutterer
Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled while a gesture is in progress. Two basic tests are added to check for the tap default setting - which is now "tap disabled by default", becau