Re: [PATCH libinput 0/24] Tablet support

2014-06-02 Thread Jonas Ã…dahl
On Mon, Jun 02, 2014 at 10:25:02AM -0700, Bill Spitzak wrote: > On 06/01/2014 09:18 PM, Peter Hutterer wrote: > > >libinput doesn't communicate over the wire, li_fixed_t is a leftover from > >libinput being part of weston. Switching that to double would indeed make > >things a lot easier and decou

Re: [PATCH libinput 0/24] Tablet support

2014-06-02 Thread Bill Spitzak
On 06/01/2014 09:18 PM, Peter Hutterer wrote: libinput doesn't communicate over the wire, li_fixed_t is a leftover from libinput being part of weston. Switching that to double would indeed make things a lot easier and decouple libinput from wl-protocol-specific things. I'd be all up for it, tho

Re: [PATCH libinput 0/24] Tablet support

2014-06-01 Thread Peter Hutterer
On Fri, May 30, 2014 at 11:18:08AM -0700, Jason Gerecke wrote: > On Thu, May 29, 2014 at 11:45 PM, Daniel Stone wrote: > > On 29 May 2014 18:54, Jason Gerecke wrote: > >> > >> If that's the case though, I have to ask -- *why* on Earth is > >> 'li_fixed_t' even being considered as libinput's outpu

Re: [PATCH libinput 0/24] Tablet support

2014-05-30 Thread Chandler Paul
Hi! I've been busy at work fixing up the set of patches that carlos sent and I've finally got some commits up. This is rebased from the original branch that I linked to (carlos_cleanup) to work with the latest upstream master. You can find it here: https://github.com/Lyude1337/libinput/tre

Re: [PATCH libinput 0/24] Tablet support

2014-05-30 Thread Bill Spitzak
My first question is that ints are allowed in the api, so why is it not using them instead of fixed. I think it is a lot clearer to say the maximum value is 0x7FFF than 16777215.99609375. The bit pattern sent is identical so it is simply a documentation question. I'm now thinking that norm

Re: [PATCH libinput 0/24] Tablet support

2014-05-30 Thread Jason Gerecke
On Thu, May 29, 2014 at 11:45 PM, Daniel Stone wrote: > On 29 May 2014 18:54, Jason Gerecke wrote: >> >> If that's the case though, I have to ask -- *why* on Earth is >> 'li_fixed_t' even being considered as libinput's output type? I know >> I'm missing something because the thought seems like su

Re: [PATCH libinput 0/24] Tablet support

2014-05-29 Thread Daniel Stone
On 29 May 2014 18:54, Jason Gerecke wrote: > If that's the case though, I have to ask -- *why* on Earth is > 'li_fixed_t' even being considered as libinput's output type? I know > I'm missing something because the thought seems like such a blindingly > terrible choice. Its not an intrinsic type,

Re: [PATCH libinput 0/24] Tablet support

2014-05-29 Thread Jason Gerecke
On Wed, May 28, 2014 at 6:39 PM, Peter Hutterer wrote: > On Wed, May 28, 2014 at 10:23:00AM -0700, Jason Gerecke wrote: >> On Tue, May 27, 2014 at 8:32 PM, Chandler Paul wrote: >> > On Wed, 2014-05-28 at 12:48 +1000, Peter Hutterer wrote: >> >> On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gere

Re: [PATCH libinput 0/24] Tablet support

2014-05-29 Thread Peter Hutterer
On Wed, May 28, 2014 at 11:07:52AM -0700, Bill Spitzak wrote: > I'm not clear on why there is an attempt to use FIXED for the data rather > than an integer. The binary result is identical, but I think it is a lot > easier and clearer to say that the numbers range from -2147483647 to > +2147483647 (

Re: [PATCH libinput 0/24] Tablet support

2014-05-28 Thread Peter Hutterer
On Wed, May 28, 2014 at 10:23:00AM -0700, Jason Gerecke wrote: > On Tue, May 27, 2014 at 8:32 PM, Chandler Paul wrote: > > On Wed, 2014-05-28 at 12:48 +1000, Peter Hutterer wrote: > >> On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: > >> > On Tue, May 27, 2014 at 3:20 PM, Peter Hutt

Re: [PATCH libinput 0/24] Tablet support

2014-05-28 Thread Bill Spitzak
I'm not clear on why there is an attempt to use FIXED for the data rather than an integer. The binary result is identical, but I think it is a lot easier and clearer to say that the numbers range from -2147483647 to +2147483647 (or -0x7fff to 0x7fff). It seems like the following inform

Re: [PATCH libinput 0/24] Tablet support

2014-05-28 Thread Jason Gerecke
On Tue, May 27, 2014 at 8:32 PM, Chandler Paul wrote: > On Wed, 2014-05-28 at 12:48 +1000, Peter Hutterer wrote: >> On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: >> > On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer >> > wrote: >> > > On Tue, May 27, 2014 at 04:32:14PM -0400, Chan

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Chandler Paul
On Tue, 2014-05-27 at 23:32 -0400, Chandler Paul wrote: > On Wed, 2014-05-28 at 12:48 +1000, Peter Hutterer wrote: > > On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: > > > On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer > > > wrote: > > > > On Tue, May 27, 2014 at 04:32:14PM -0400,

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Chandler Paul
On Wed, 2014-05-28 at 12:48 +1000, Peter Hutterer wrote: > On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: > > On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer > > wrote: > > > On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: > > >> On Tue, 2014-05-27 at 13:11 -0700, Ja

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 03:40:07PM -0700, Jason Gerecke wrote: > On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer > wrote: > > On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: > >> On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: > >> > I've been away from my computer for most

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Chandler Paul
On Tue, 2014-05-27 at 15:40 -0700, Jason Gerecke wrote: > On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer > wrote: > > On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: > >> On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: > >> > I've been away from my computer for most of the

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Jason Gerecke
On Tue, May 27, 2014 at 3:52 PM, Peter Hutterer wrote: > On Tue, May 27, 2014 at 01:11:31PM -0700, Jason Gerecke wrote: >> I've been away from my computer for most of the (long) weekend up >> here, so apologies for being a bit quiet :) >> >> >> On Sun, May 25, 2014 at 7:13 PM, Peter Hutterer >> w

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 01:11:31PM -0700, Jason Gerecke wrote: > I've been away from my computer for most of the (long) weekend up > here, so apologies for being a bit quiet :) > > > On Sun, May 25, 2014 at 7:13 PM, Peter Hutterer > wrote: > > On Fri, May 23, 2014 at 10:34:10PM -0400, Chandler P

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Chandler Paul
On Wed, 2014-05-28 at 08:20 +1000, Peter Hutterer wrote: > On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: > > On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: > > > I've been away from my computer for most of the (long) weekend up > > > here, so apologies for being a bit quie

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Jason Gerecke
On Tue, May 27, 2014 at 3:20 PM, Peter Hutterer wrote: > On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: >> On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: >> > I've been away from my computer for most of the (long) weekend up >> > here, so apologies for being a bit quiet :)

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Peter Hutterer
On Tue, May 27, 2014 at 04:32:14PM -0400, Chandler Paul wrote: > On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: > > I've been away from my computer for most of the (long) weekend up > > here, so apologies for being a bit quiet :) > > > There's a subtlety on the protocol side of things tha

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Chandler Paul
On Tue, 2014-05-27 at 13:11 -0700, Jason Gerecke wrote: > I've been away from my computer for most of the (long) weekend up > here, so apologies for being a bit quiet :) > There's a subtlety on the protocol side of things that can't be > ignored. When normalizing data, you want to be careful to pr

Re: [PATCH libinput 0/24] Tablet support

2014-05-27 Thread Jason Gerecke
I've been away from my computer for most of the (long) weekend up here, so apologies for being a bit quiet :) On Sun, May 25, 2014 at 7:13 PM, Peter Hutterer wrote: > On Fri, May 23, 2014 at 10:34:10PM -0400, Chandler Paul wrote: >> On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: >> > I

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Fri, May 23, 2014 at 10:34:10PM -0400, Chandler Paul wrote: > On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: > > I'm almost sold on normalization since it does reduce the likelihood of > > things going wrong. We need to provide the axis resolution to convert back > > to the real data t

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Peter Hutterer
On Mon, May 26, 2014 at 02:27:35AM +0200, Carlos Garnacho wrote: > Hey Peter, > > On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: > > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > > Hi, > > > > > > First of all, I'm sorry I dropped the ball this long. It's great to

Re: [PATCH libinput 0/24] Tablet support

2014-05-25 Thread Carlos Garnacho
Hey Peter, On vie, 2014-05-23 at 16:19 +1000, Peter Hutterer wrote: > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > Hi, > > > > First of all, I'm sorry I dropped the ball this long. It's great to see > > you've been doing some progress. > > > > On jue, 2014-05-22 at 01:17

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Chandler Paul
On Fri, 2014-05-23 at 17:00 +1000, Peter Hutterer wrote: > I'm almost sold on normalization since it does reduce the likelihood of > things going wrong. We need to provide the axis resolution to convert back > to the real data though where needed. > > once you provide the axis resolution, it doesn

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Fri, May 23, 2014 at 01:43:10AM +0200, Carlos Garnacho wrote: [...] > You make a good point with tilt axes below. I think this at least stands > true for ABS_PRESSURE, a device with 1024 possible values doesn't > register 4x as much pressure as a device with 256 values, those are > rather the "

Re: [PATCH libinput 0/24] Tablet support

2014-05-23 Thread Peter Hutterer
On Thu, May 22, 2014 at 03:37:44PM -0400, Chandler Paul wrote: > On Thu, 2014-05-22 at 11:17 -0700, Jason Gerecke wrote: > > On Wed, May 21, 2014 at 10:17 PM, Chandler Paul > > wrote: > > > Hi! Sorry this took so long to write, I've been spending a lot of my > > > time recently trying to understa

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Peter Hutterer
On Fri, May 23, 2014 at 02:30:45AM -0400, Jasper St. Pierre wrote: > On Fri, May 23, 2014 at 2:19 AM, Peter Hutterer > wrote: > > > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > > Hi, > > > > > > First of all, I'm sorry I dropped the ball this long. It's great to see > > >

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Jasper St. Pierre
On Fri, May 23, 2014 at 2:19 AM, Peter Hutterer wrote: > On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > > Hi, > > > > First of all, I'm sorry I dropped the ball this long. It's great to see > > you've been doing some progress. > > > > On jue, 2014-05-22 at 01:17 -0400, Chandler

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Peter Hutterer
On Fri, May 23, 2014 at 01:40:49AM +0200, Carlos Garnacho wrote: > Hi, > > First of all, I'm sorry I dropped the ball this long. It's great to see > you've been doing some progress. > > On jue, 2014-05-22 at 01:17 -0400, Chandler Paul wrote: > > Hi! Sorry this took so long to write, I've been spe

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Ping Cheng
On Thu, May 22, 2014 at 4:55 PM, Carlos Garnacho wrote: > Hi Ping! > > On lun, 2014-04-21 at 18:03 -0700, Ping Cheng wrote: >> Benjamin is right. Those are absolute values. Most Linux applications >> do not use those extra values. But, there are in-house applications >> need those values. I'll hav

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Ping Cheng
On Wed, May 21, 2014 at 10:17 PM, Chandler Paul wrote: > Hi! Sorry this took so long to write, I've been spending a lot of my > time recently trying to understand the libinput code and all of that > good stuff, and I wanted to make sure I had a decent understanding of it > before I actually wrote

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Benjamin Tissoires
On Thu, May 22, 2014 at 1:17 AM, Chandler Paul wrote: > Hi! Sorry this took so long to write, I've been spending a lot of my > time recently trying to understand the libinput code and all of that > good stuff, and I wanted to make sure I had a decent understanding of it > before I actually wrote u

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
Hi Ping! On lun, 2014-04-21 at 18:03 -0700, Ping Cheng wrote: > Benjamin is right. Those are absolute values. Most Linux applications > do not use those extra values. But, there are in-house applications > need those values. I'll have to ask around to give you some use cases > if you are intereste

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
Hey Jason, On jue, 2014-05-22 at 11:17 -0700, Jason Gerecke wrote: > On Wed, May 21, 2014 at 10:17 PM, Chandler Paul wrote: > > Hi! Sorry this took so long to write, I've been spending a lot of my > > time recently trying to understand the libinput code and all of that > > good stuff, and I wante

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Carlos Garnacho
Hi, First of all, I'm sorry I dropped the ball this long. It's great to see you've been doing some progress. On jue, 2014-05-22 at 01:17 -0400, Chandler Paul wrote: > Hi! Sorry this took so long to write, I've been spending a lot of my > time recently trying to understand the libinput code and al

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Chandler Paul
On Thu, 2014-05-22 at 11:17 -0700, Jason Gerecke wrote: > On Wed, May 21, 2014 at 10:17 PM, Chandler Paul wrote: > > Hi! Sorry this took so long to write, I've been spending a lot of my > > time recently trying to understand the libinput code and all of that > > good stuff, and I wanted to make su

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Jason Gerecke
On Wed, May 21, 2014 at 10:17 PM, Chandler Paul wrote: > Hi! Sorry this took so long to write, I've been spending a lot of my > time recently trying to understand the libinput code and all of that > good stuff, and I wanted to make sure I had a decent understanding of it > before I actually wrote

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Jason Gerecke
On Thu, May 22, 2014 at 8:45 AM, Bill Spitzak wrote: >>>- One device has 2 strips, which report on ABS_RX/RY (radial??). >>> Min/max >>> are 0..4096, but the reported values are 1,2,4,8,16... So >>> effectively >>> a log2 scale, or more graphically a bit shifting over a bunch of 0s,

Re: [PATCH libinput 0/24] Tablet support

2014-05-22 Thread Bill Spitzak
- One device has 2 strips, which report on ABS_RX/RY (radial??). Min/max are 0..4096, but the reported values are 1,2,4,8,16... So effectively a log2 scale, or more graphically a bit shifting over a bunch of 0s, which is somewhat more resembling to the physical action on the stri

Re: [PATCH libinput 0/24] Tablet support

2014-05-21 Thread Chandler Paul
Hi! Sorry this took so long to write, I've been spending a lot of my time recently trying to understand the libinput code and all of that good stuff, and I wanted to make sure I had a decent understanding of it before I actually wrote up a response. On Mon, 2014-04-21 at 19:11 +0200, Carlos Garnac

Re: [PATCH libinput 0/24] Tablet support

2014-04-27 Thread Peter Hutterer
Hey, On Mon, Apr 21, 2014 at 07:11:09PM +0200, Carlos Garnacho wrote: > Hey there!, > > Here's a few patches to have libinput handle events from tablets, > these devices are basically pointer devices, with a varying range > of extra buttons (either stylus or "pad" buttons), and extra ABS_* > axes

Re: [PATCH libinput 0/24] Tablet support

2014-04-21 Thread Ping Cheng
On Mon, Apr 21, 2014 at 4:40 PM, Benjamin Tissoires wrote: > Hi Carlos, > > [Adding a few people to the conversation] > > I am working a little bit on the wacom.ko kernel driver and I can give > you some hints on the oddness around the events. > > On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho

Re: [PATCH libinput 0/24] Tablet support

2014-04-21 Thread Benjamin Tissoires
Hi Carlos, [Adding a few people to the conversation] I am working a little bit on the wacom.ko kernel driver and I can give you some hints on the oddness around the events. On Mon, Apr 21, 2014 at 1:11 PM, Carlos Garnacho wrote: > Hey there!, > > Here's a few patches to have libinput handle eve

[PATCH libinput 0/24] Tablet support

2014-04-21 Thread Carlos Garnacho
Hey there!, Here's a few patches to have libinput handle events from tablets, these devices are basically pointer devices, with a varying range of extra buttons (either stylus or "pad" buttons), and extra ABS_* axes. These devices also often offer information about the stylus in use, and its BTN_T