Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

2018-05-09 Thread Peter Hutterer
On Thu, May 10, 2018 at 12:46:02AM +0200, Friedrich Schöller wrote: > On 09.05.2018 06:34, Peter Hutterer wrote: > > On Sat, May 05, 2018 at 03:49:32AM +0200, Friedrich Schöller wrote: > > thanks, patch looks good and is merged locally. Any chance I can convince > > you to write a test case for thi

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

2018-05-09 Thread Friedrich Schöller
On 09.05.2018 06:34, Peter Hutterer wrote: On Sat, May 05, 2018 at 03:49:32AM +0200, Friedrich Schöller wrote: thanks, patch looks good and is merged locally. Any chance I can convince you to write a test case for this? :) Would make sure that we're not breaking this again. Nice to hear! I wrot

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

2018-05-08 Thread Peter Hutterer
On Sat, May 05, 2018 at 03:49:32AM +0200, Friedrich Schöller wrote: > When finger movement exceeded the motion threshold before the finger was > recognized as a thumb, it would never be regarded as a thumb by the tap > system. > This prohibited tapping until the thumb was lifted. > > This is fixe

[PATCH libinput] touchpad: fix tapping that happens after a moving thumb

2018-05-04 Thread Friedrich Schöller
When finger movement exceeded the motion threshold before the finger was recognized as a thumb, it would never be regarded as a thumb by the tap system. This prohibited tapping until the thumb was lifted. This is fixed by moving the check for the thumb state up such that it happens before the moti

Re: [PATCH libinput] touchpad: fix tapping that happens after a moving thumb

2018-05-04 Thread Friedrich Schöller
I have attached an evemu recording that illustrates the issue. In the recording a thumb touches the touchpad, gets state THUMB_STATE_MAYBE, then THUMB_STATE_YES. After that, a tap is performed, but it is ignored without the patch. Best, Friedrich On 05.05.2018 03:49, Friedrich Schöller wrote: