Re: [PATCH libinput] timer: drain data on the timerfd when it triggers

2015-04-30 Thread Peter Hutterer
On Thu, Apr 30, 2015 at 09:24:41AM -0500, Derek Foreman wrote: > On 29/04/15 08:33 PM, Peter Hutterer wrote: > > Signed-off-by: Peter Hutterer > > --- > > I admit, I'm not sure of the effect it has leaving the data sitting there. > > timerfd_create states that only the value read changes, not the

Re: [PATCH libinput] timer: drain data on the timerfd when it triggers

2015-04-30 Thread Derek Foreman
On 29/04/15 08:33 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > I admit, I'm not sure of the effect it has leaving the data sitting there. > timerfd_create states that only the value read changes, not the actual size > of the data (which I couldn't reproduce in a quick test, it

Re: [PATCH libinput] timer: drain data on the timerfd when it triggers

2015-04-30 Thread Hans de Goede
Hi, On 30-04-15 03:33, Peter Hutterer wrote: Signed-off-by: Peter Hutterer It seems this is the right thing todo: Reviewed-by: Hans de Goede Regards, Hans --- I admit, I'm not sure of the effect it has leaving the data sitting there. timerfd_create states that only the value read chan

[PATCH libinput] timer: drain data on the timerfd when it triggers

2015-04-29 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- I admit, I'm not sure of the effect it has leaving the data sitting there. timerfd_create states that only the value read changes, not the actual size of the data (which I couldn't reproduce in a quick test, it's always 1) epoll sounds like it should keep triggeri