Re: [PATCH libinput] Fix leaking device groups

2015-09-06 Thread Peter Hutterer
On Mon, Sep 07, 2015 at 11:48:22AM +0800, Jonas Ådahl wrote: > On Mon, Sep 07, 2015 at 01:11:11PM +1000, Peter Hutterer wrote: > > If a caller has a reference to a device group when the context is destroyed, > > the memory for the group is never released. Calling > > libinput_device_group_unref() w

Re: [PATCH libinput] Fix leaking device groups

2015-09-06 Thread Jonas Ådahl
On Mon, Sep 07, 2015 at 01:11:11PM +1000, Peter Hutterer wrote: > If a caller has a reference to a device group when the context is destroyed, > the memory for the group is never released. Calling > libinput_device_group_unref() will release it and there are no side-effects > since the group has no

[PATCH libinput] Fix leaking device groups

2015-09-06 Thread Peter Hutterer
If a caller has a reference to a device group when the context is destroyed, the memory for the group is never released. Calling libinput_device_group_unref() will release it and there are no side-effects since the group has no back-references. It's inconsistent with the rest of libinput though - a