Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-05 Thread Olivier Fourdan
On 05/02/15 11:26, Olivier Fourdan wrote:> On 05/02/15 02:30, Peter Hutterer wrote: >> On Wed, Feb 04, 2015 at 04:45:37PM -0500, Olivier Fourdan wrote: >>> Hi Peter, >>> >>> Just to clarify, evdev_accel_config_set_speed() calls filter_set_speed() >>> which calls accelerator_set_speed() which re

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-05 Thread Olivier Fourdan
Hey Peter, On 05/02/15 02:30, Peter Hutterer wrote: On Wed, Feb 04, 2015 at 04:45:37PM -0500, Olivier Fourdan wrote: Hi Peter, Just to clarify, evdev_accel_config_set_speed() calls filter_set_speed() which calls accelerator_set_speed() which reaches the assert(). My patch basically removes th

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Peter Hutterer
ourdan" > To: "Peter Hutterer" > Cc: wayland-devel@lists.freedesktop.org > Sent: Wednesday, 4 February, 2015 10:28:22 PM > Subject: Re: [PATCH libinput] Do not abort on invalid speed. > > Hi Peter, > > Weird, that occurs with xf86-drv-libinput and libinp

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
- From: "Olivier Fourdan" To: "Peter Hutterer" Cc: wayland-devel@lists.freedesktop.org Sent: Wednesday, 4 February, 2015 10:28:22 PM Subject: Re: [PATCH libinput] Do not abort on invalid speed. Hi Peter, Weird, that occurs with xf86-drv-libinput and libinput both from git as

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
.. Cheers, Olivier - Original Message - From: "Peter Hutterer" To: "Olivier Fourdan" Cc: wayland-devel@lists.freedesktop.org Sent: Wednesday, 4 February, 2015 10:15:56 PM Subject: Re: [PATCH libinput] Do not abort on invalid speed. On Wed, Feb 04, 2015 at 10:34:25A

Re: [PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Peter Hutterer
On Wed, Feb 04, 2015 at 10:34:25AM +0100, Olivier Fourdan wrote: > Libinput's accelerator_set_speed() asserts the given speed value is > within the [-1.0, 1.0] range. > > When using xf86-input-libinput, a client may try to set an invalid speed > which will cause the entire Xserver to abort. > > I

[PATCH libinput] Do not abort on invalid speed.

2015-02-04 Thread Olivier Fourdan
Libinput's accelerator_set_speed() asserts the given speed value is within the [-1.0, 1.0] range. When using xf86-input-libinput, a client may try to set an invalid speed which will cause the entire Xserver to abort. Instead of aborting on invalid speed values, simply return a failure (and log a