Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-07-01 Thread Peter Hutterer
On Tue, Jul 01, 2014 at 08:49:56PM +0200, jad...@gmail.com wrote: > On Fri, Jun 27, 2014 at 01:02:11PM +1000, Peter Hutterer wrote: > > Those three are the ones that matter for logging or device identification in > > callers, so let's provide them. > > > > Signed-off-by: Peter Hutterer > > Revie

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-07-01 Thread jadahl
On Fri, Jun 27, 2014 at 01:02:11PM +1000, Peter Hutterer wrote: > Those three are the ones that matter for logging or device identification in > callers, so let's provide them. > > Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ã…dahl with a nit below. Jonas > --- > src/evdev.c| 18 +++

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-06-29 Thread Peter Hutterer
On Fri, Jun 27, 2014 at 10:10:30AM -0700, Jason Gerecke wrote: > On Thu, Jun 26, 2014 at 8:02 PM, Peter Hutterer > wrote: > > Those three are the ones that matter for logging or device identification in > > callers, so let's provide them. > > > > Signed-off-by: Peter Hutterer > > Have you though

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-06-27 Thread Jason Gerecke
On Thu, Jun 26, 2014 at 8:02 PM, Peter Hutterer wrote: > Those three are the ones that matter for logging or device identification in > callers, so let's provide them. > > Signed-off-by: Peter Hutterer Have you thought about how to handle identification for non-USB devices? We're starting to see

Re: [PATCH libinput] Add functions to get the device name, PID and VID

2014-06-27 Thread Hans de Goede
Hi, On 06/27/2014 05:02 AM, Peter Hutterer wrote: > Those three are the ones that matter for logging or device identification in > callers, so let's provide them. > > Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans > --- > src/evdev.c| 18 ++

[PATCH libinput] Add functions to get the device name, PID and VID

2014-06-26 Thread Peter Hutterer
Those three are the ones that matter for logging or device identification in callers, so let's provide them. Signed-off-by: Peter Hutterer --- src/evdev.c| 18 ++ src/evdev.h| 9 + src/libinput.c | 18 ++ src/libinput.h | 34 ++