Re: [PATCH fullscreen-shell v5 18/18] Add a screen sharing plugin

2014-04-02 Thread Andrew Wedgbury
On Tue, 18 Mar 2014, Jason Ekstrand wrote: +static struct shared_output * +weston_output_share(struct weston_output *output, + const char *path, char *const argv[]) +{ + int sv[2]; + char str[32]; + pid_t pid; + sigset_t allsigs; + + if (socketpai

Re: [PATCH fullscreen-shell v5 18/18] Add a screen sharing plugin

2014-03-27 Thread Jason Ekstrand
Andrew, Thanks for reviewing. Comments follow. On Mar 27, 2014 7:02 AM, "Andrew Wedgbury" wrote: > > Hi Jason, > > A few comments I have from trying out your fullscreen-shell changes: > > > On Tue, 18 Mar 2014, Jason Ekstrand wrote: > >> +static struct ss_seat * >> +ss_seat_create(struct shared_

Re: [PATCH fullscreen-shell v5 18/18] Add a screen sharing plugin

2014-03-27 Thread Andrew Wedgbury
Hi Jason, A few comments I have from trying out your fullscreen-shell changes: On Tue, 18 Mar 2014, Jason Ekstrand wrote: +static struct ss_seat * +ss_seat_create(struct shared_output *so, uint32_t id) +{ + struct ss_seat *seat; + + seat = zalloc(sizeof *seat); + if (seat == NULL)

[PATCH fullscreen-shell v5 18/18] Add a screen sharing plugin

2014-03-17 Thread Jason Ekstrand
This adds a plugin called screen-share.so. If the screen-share.so module is imported, it will add the CTRL+ALT+s keybinding to start a screen sharing session. If you press CTRL+ALT+S, weston will spawn another copy of weston, this time with the RDP backend, and mirrors the current screen to it an