On 14-10-30 04:06 AM, Pekka Paalanen wrote:
Below I'll attach what I had written earlier but not sent, because
then I realized the server vs. weston-desktop-shell thing. If we do
autolaunch in the server, the below more or less applies again.
**
Okay, if Fred or someone actually has time to do
On Wed, 29 Oct 2014 20:01:33 +
Daniel Stone wrote:
> Hi,
>
> On Wednesday, October 29, 2014, Pekka Paalanen <
> pekka.paala...@collabora.co.uk> wrote:
>
> > On Tue, 28 Oct 2014 16:46:24 +
> > Daniel Stone > wrote:
> > > On 24 October 2014 11:18, Pekka Paalanen > >
> > > wrote:
> > I th
Hi,
On Wednesday, October 29, 2014, Pekka Paalanen <
pekka.paala...@collabora.co.uk> wrote:
> On Tue, 28 Oct 2014 16:46:24 +
> Daniel Stone > wrote:
> > On 24 October 2014 11:18, Pekka Paalanen >
> > wrote:
> I think we all forgot a tiny detail here.
>
> weston_client_start() is a compositor
On Tue, 28 Oct 2014 16:46:24 +
Daniel Stone wrote:
> Hi,
>
> On 24 October 2014 11:18, Pekka Paalanen
> wrote:
>
> > On Fri, 24 Oct 2014 10:28:57 +0100
> > Daniel Stone wrote:
> > >
> > > Hmm. Can we please use weston_client_start here instead of open-coding
> > it?
> >
> > weston_client_
Hi,
On 24 October 2014 11:18, Pekka Paalanen
wrote:
> On Fri, 24 Oct 2014 10:28:57 +0100
> Daniel Stone wrote:
> >
> > Hmm. Can we please use weston_client_start here instead of open-coding
> it?
>
> weston_client_start() does not support passing in environment
> explicitly.
Entirely fixable.
On Fri, 24 Oct 2014 14:47:00 -0700
Bryce Harrington wrote:
> On Fri, Oct 24, 2014 at 01:18:51PM +0300, Pekka Paalanen wrote:
> > > And, while you're at it - as this was written for kiosk mode, it spawns a
> > > shell script which just restarts the video player in a loop. Can we please
> > > add a
On Fri, Oct 24, 2014 at 01:18:51PM +0300, Pekka Paalanen wrote:
> > And, while you're at it - as this was written for kiosk mode, it spawns a
> > shell script which just restarts the video player in a loop. Can we please
> > add an autostart param to weston_client_run/start (as a new enum with
> >
Hi,
On 22 October 2014 14:53, Pekka Paalanen
wrote:
> + pid = fork();
> + if (pid < 0) {
> + fprintf(stderr, "fork failed: %m\n");
> + goto out;
> + }
> +
> + if (pid)
> + goto out;
> +
> + argvpp = argv.data;
> + if (
On Fri, 24 Oct 2014 10:28:57 +0100
Daniel Stone wrote:
> Hi,
>
> On 22 October 2014 14:53, Pekka Paalanen
> wrote:
>
> > + pid = fork();
> > + if (pid < 0) {
> > + fprintf(stderr, "fork failed: %m\n");
> > + goto out;
> > + }
> > +
> > + if (
On Thu, 23 Oct 2014 15:07:01 -0400
Frederic Plourde wrote:
> +1 for refactoring in a separate patch.
> by merging the change with panel_add_launcher in the same patch, it gets
> *really* hard to read because of the intertwining.
Yeah, please split it.
Btw. it was Fred who actually sent the pat
+1 for refactoring in a separate patch.
by merging the change with panel_add_launcher in the same patch,
it gets *really* hard to read because of the intertwining.
now, for exit() instead of using EXIT_FAILURE/SUCCESS,
currently there is roughly 50 usages o
The %m from glibc would indeed be a portability problem. However, it is already
lightly used within wayland (11 occurrences) and heavily in weston (125
occurrences). I suggest you keep them for now, then clean them all up in one
patch later - assuming the wayland community and prospective users
I'd prefer to see the refactor and the new feature in separate patches,
but this is pretty trivial.
I also have a slight preference for exit(EXIT_FAILURE), which is already
used somewhere else in that file - though there's also precedent for
exit(1), so you make the call. :)
I'd not seen printf'
Process a new section 'autolaunch' from weston.ini, launching all
programs given there on desktop start-up.
[Frederic Plourde: cut redundancy between do_autolaunch and panel_add_launcher]
---
clients/desktop-shell.c | 97 ++---
man/weston.ini.man |
14 matches
Mail list logo
