Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-28 Thread Peter Hutterer
On Thu, Jun 25, 2015 at 08:06:29AM -0700, spit...@gmail.com wrote: > From: Bill Spitzak > > (changes from previous version: rounds the guess and changes 0 to 1, > removed unused variables) > > Instead a default resolution is set if the device does not claim one. > The selected value is a guess t

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-26 Thread Bill Spitzak
On Thu, Jun 25, 2015 at 8:52 PM, Peter Hutterer wrote: > I think you're underestimating the precision of modern touchpads. The T440s > have a resolution of 42 units/mm, the x220 from several years ago had > somewhere around 130. The lowest value I've seen so far was 10. > Ok then it sounds like

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread Peter Hutterer
On Thu, Jun 25, 2015 at 08:12:36AM -0700, Bill Spitzak wrote: > Actually it seems incorrect to store the number of device units per mm as an > integer, since I would guess this number is near 1. However I don't know how > touchpads work so maybe the resolution is much much finer than I would > gues

Re: [PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread Bill Spitzak
Actually it seems incorrect to store the number of device units per mm as an integer, since I would guess this number is near 1. However I don't know how touchpads work so maybe the resolution is much much finer than I would guess? To avoid floating point it might work to store the size of the

[PATCH V3 libinput] evdev: remove checks for fake_resolution

2015-06-25 Thread spitzak
From: Bill Spitzak (changes from previous version: rounds the guess and changes 0 to 1, removed unused variables) Instead a default resolution is set if the device does not claim one. The selected value is a guess that the trackpad is 67 mm tall and that the device units are square. This estima