Re: [PATCH GSoC] desktop-shell: enhance weston-desktop-shell panel's clock

2016-03-03 Thread Armin Krezović
On 03.03.2016 11:25, Pekka Paalanen wrote: > Hi Armin, > Hi, > this is a good first step, and the patch applies cleanly. I added a > comment in bugzilla that you will be working on this. A detailed review > follows inline. I may be more nitpicky than usual, because I take this > as a teaching se

Re: [PATCH GSoC] desktop-shell: enhance weston-desktop-shell panel's clock

2016-03-03 Thread Pekka Paalanen
Hi Armin, this is a good first step, and the patch applies cleanly. I added a comment in bugzilla that you will be working on this. A detailed review follows inline. I may be more nitpicky than usual, because I take this as a teaching session. :-) IMHO the perfect subject line would be: "[PATCH w

[PATCH GSoC] desktop-shell: enhance weston-desktop-shell panel's clock

2016-03-02 Thread Armin Krezović
This patch enhances the panel clock by adding a config file option which can be used to either disable the clock or make it also show seconds in the current clock format. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57583 --- clients/desktop-shell.c | 71