Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Miguel Angel Vico
Hi, On Tue, 22 Mar 2016 09:30:51 + Daniel Stone wrote: > Hi, > > On 22 March 2016 at 08:50, Daniel Vetter wrote: > > On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: > >> This is odd. Instant queries failing is fine, but in which > >> circumstances can you fail to return a v

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Stone
Hi, On 22 March 2016 at 08:50, Daniel Vetter wrote: > On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: >> This is odd. Instant queries failing is fine, but in which >> circumstances can you fail to return a valid timestamp in a pageflip >> event ... ? I don't know of any other kernel

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Vetter
On Tue, Mar 22, 2016 at 08:47:12AM +, Daniel Stone wrote: > Hi Miguel, > > On 21 March 2016 at 16:37, Miguel A. Vico wrote: > > Instant query for vblank timestamp may always fail, resulting in > > never scheduling a full repaint in drm_output_start_repaint_loop(). > > > > Additionally, timest

Re: [PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-22 Thread Daniel Stone
Hi Miguel, On 21 March 2016 at 16:37, Miguel A. Vico wrote: > Instant query for vblank timestamp may always fail, resulting in > never scheduling a full repaint in drm_output_start_repaint_loop(). > > Additionally, timestamp provided in page_flip_handler() may also be > invalid. > > [...] > > @@

[PATCH 5/7] compositor-drm: Gracefully handle vblank and flip invalid timestamps

2016-03-21 Thread Miguel A. Vico
Instant query for vblank timestamp may always fail, resulting in never scheduling a full repaint in drm_output_start_repaint_loop(). Additionally, timestamp provided in page_flip_handler() may also be invalid. This change makes both drm_output_start_repaint_loop() and page_flip_handler() to sched