Re: [PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Tiago Vignatti
On 04/03/2012 05:18 PM, Daniel Stone wrote: On 3 April 2012 14:58, Tiago Vignatti wrote: Just moving code around. No functional changes. Sorry, I'm not sure I really like this one, unless you're planning to add an else branch; even then, that might well be fodder for helper functions. The e

Re: [PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Daniel Stone
Hi, On 3 April 2012 14:58, Tiago Vignatti wrote: > Just moving code around. No functional changes. Sorry, I'm not sure I really like this one, unless you're planning to add an else branch; even then, that might well be fodder for helper functions. The early-return style is good not only at redu

[PATCH 5/6 xserver] xwayland: make more explicit root window creation path

2012-04-03 Thread Tiago Vignatti
Just moving code around. No functional changes. Signed-off-by: Tiago Vignatti --- hw/xfree86/xwayland/xwayland-window.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hw/xfree86/xwayland/xwayland-window.c b/hw/xfree86/xwayland/xwayland-wi