Re: [PATCH 5/5] Weston: fix drmModeRmFB

2012-03-31 Thread Pekka Paalanen
On Sat, 31 Mar 2012 16:00:59 +0200 Andreas Ericsson wrote: > On 03/31/2012 12:58 PM, Martin Minarik wrote: > > fb_id is unsigned integer, we are assigning -1 to it. Changed > > to 0x should be better. > > > > 0x is within the range for the maximum usable filedescriptor > on Linux, and n

Re: [PATCH 5/5] Weston: fix drmModeRmFB

2012-03-31 Thread Andreas Ericsson
On 03/31/2012 12:58 PM, Martin Minarik wrote: > fb_id is unsigned integer, we are assigning -1 to it. Changed to 0x > should be better. > 0x is within the range for the maximum usable filedescriptor on Linux, and not even very uncommon a setting, at that. Use ~0 instead, or change fb_id t

[PATCH 5/5] Weston: fix drmModeRmFB

2012-03-31 Thread Martin Minarik
fb_id is unsigned integer, we are assigning -1 to it. Changed to 0x should be better. diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 4305cd5..f43f652 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1041,8 +1041,9 @@ create_output_for_connector(struct drm_comp