Re: [PATCH 2/4] config: fix boolean parsing

2011-11-15 Thread Kristian Høgsberg
On Tue, Nov 15, 2011 at 9:27 AM, Alexandre Bique wrote: > On Tue, Nov 15, 2011 at 10:45 AM, Pekka Paalanen wrote: >> The rest of the line contains the newline, so cannot match simply 'true' >> or 'false'. > > Hi Pekka, > > I am not familiar with wayland's code and I didn't even read it. > But it

Re: [PATCH 2/4] config: fix boolean parsing

2011-11-15 Thread Alexandre Bique
On Tue, Nov 15, 2011 at 10:45 AM, Pekka Paalanen wrote: > The rest of the line contains the newline, so cannot match simply 'true' > or 'false'. Hi Pekka, I am not familiar with wayland's code and I didn't even read it. But it feels weird to include the trailing \n of the value when parsing the

Re: [PATCH 2/4] config: fix boolean parsing

2011-11-15 Thread Kristian Høgsberg
On Tue, Nov 15, 2011 at 4:45 AM, Pekka Paalanen wrote: > The rest of the line contains the newline, so cannot match simply 'true' > or 'false'. Thank you, applied. I obviously didn't test that one. Kristian > Signed-off-by: Pekka Paalanen > --- >  clients/config.c |    4 ++-- >  1 files change

[PATCH 2/4] config: fix boolean parsing

2011-11-15 Thread Pekka Paalanen
The rest of the line contains the newline, so cannot match simply 'true' or 'false'. Signed-off-by: Pekka Paalanen --- clients/config.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/config.c b/clients/config.c index 42acee7..be7b5db 100644 --- a/clients/conf