Re: [fullscreen-v8 PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-28 Thread Kristian Hoegsberg
On Tue, Feb 28, 2012 at 06:08:38PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu > > All the fullscreen things (black surface, raise atop panels, transform, > positioning) > are handled in map() or configure(). Ok, looking good, we're almost there now :) A few comments below (and plea

[fullscreen-v8 PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-28 Thread zhiwen . wu
From: Alex Wu All the fullscreen things (black surface, raise atop panels, transform, positioning) are handled in map() or configure(). Signed-off-by: Alex Wu Signed-off-by: Juan Zhao --- src/shell.c | 231 ++- 1 files changed, 214 ins

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-27 Thread Bill Spitzak
wuzhiwen wrote: I am thinking of the solution that we can specify in the protocol that if client choose to "scale" method, that means client will ignore the configure event. That will not work, as the client still needs to redraw the surface without the window borders. It may not want the cur

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-27 Thread Kristian Høgsberg
ail.com] >>Sent: Monday, February 27, 2012 3:50 PM >>To: wuzhiwen >>Cc: 'Kristian Hoegsberg'; juan.j.z...@linux.intel.com; k...@bitplanet.net; >>wayland-devel@lists.freedesktop.org >>Subject: Re: [PATCH 2/3] shell: Add implementation of fullscreen. >&

RE: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-27 Thread wuzhiwen
lanet.net; >wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH 2/3] shell: Add implementation of fullscreen. > >Sorry for jumping in... > >On Mon, 27 Feb 2012 14:25:23 +0800 >"wuzhiwen" wrote: > >> >> shell_surface_set_fullscreen(struct wl_c

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-26 Thread Pekka Paalanen
Sorry for jumping in... On Mon, 27 Feb 2012 14:25:23 +0800 "wuzhiwen" wrote: > >> shell_surface_set_fullscreen(struct wl_client *client, { > >>struct shell_surface *shsurf = resource->data; > >>struct weston_surface *es = shsurf->surface; > >> - struct weston_output *output; > >> + st

RE: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-26 Thread wuzhiwen
, 2012 4:03 AM >To: zhiwen...@linux.intel.com >Cc: juan.j.z...@linux.intel.com; k...@bitplanet.net; ppaala...@gmail.com; >wayland-devel@lists.freedesktop.org >Subject: Re: [PATCH 2/3] shell: Add implementation of fullscreen. > >On Sun, Feb 26, 2012 at 03:21:37PM +0800, zhiwen...@lin

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-26 Thread Juan Zhao
Thanks a lot for review! Still have one question: On 02/27/2012 04:02 AM, Kristian Hoegsberg wrote: + if (es->output) { This is never true since reset_shell_surface_type() unmaps it. But even when that is fixed, we can't change the surface position, size or stacking until we receive the

Re: [PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-26 Thread Kristian Hoegsberg
On Sun, Feb 26, 2012 at 03:21:37PM +0800, zhiwen...@linux.intel.com wrote: > From: Alex Wu Nice. There are a few issues below and one thing I didn't figure out right now was that when you raise a window over the fullscreen window and then re-raise the fullscreen window, the black surface renders

[PATCH 2/3] shell: Add implementation of fullscreen.

2012-02-25 Thread zhiwen . wu
From: Alex Wu For now, fullscreen surface will be atop panels and with a black surface underlying it. Only the WL_SHELL_SURFACE_FULLSCREEN_METHOD_SCALE method implemented in this patch. For other methods, just center on the surface. --- src/shell.c | 207 ++