Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread John Kåre Alsaker
On Tue, Jan 8, 2013 at 9:14 PM, Vasily Khoruzhick wrote: > On Tue, Jan 8, 2013 at 10:50 PM, John Kåre Alsaker > wrote: > > Hi John, > >> I'd like for output_create, output_destroy, renderer_destroy, >> set_border and repaint_output to be virtual functions as part of a new >> abstraction which is

Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread Vasily Khoruzhick
On Tue, Jan 8, 2013 at 10:50 PM, John Kåre Alsaker wrote: Hi John, > I'd like for output_create, output_destroy, renderer_destroy, > set_border and repaint_output to be virtual functions as part of a new > abstraction which is responsible for handling buffers and renderers > for the backends. Th

Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread John Kåre Alsaker
I'd like for output_create, output_destroy, renderer_destroy, set_border and repaint_output to be virtual functions as part of a new abstraction which is responsible for handling buffers and renderers for the backends. These may simply be new fields in weston_renderer that the backends override as

Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread Kristian Høgsberg
On Tue, Jan 8, 2013 at 1:36 PM, John Kåre Alsaker wrote: > I'd like to see this callback in a buffer manager abstraction which > could encapsulate EGL and X11/fb/kms buffer management and get rid of > duplicated code for the renderers. However if it's added to > weston_renderer, it should be destr

Re: [PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread John Kåre Alsaker
I'd like to see this callback in a buffer manager abstraction which could encapsulate EGL and X11/fb/kms buffer management and get rid of duplicated code for the renderers. However if it's added to weston_renderer, it should be destroyed by the compositor and not by the backends. On Tue, Jan 8, 20

[PATCH 2/3] renderer: introduce destroy callback

2013-01-08 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- src/compositor-android.c | 6 +++--- src/compositor-drm.c | 4 ++-- src/compositor-headless.c | 2 +- src/compositor-rpi.c | 4 ++-- src/compositor-wayland.c | 4 ++-- src/compositor-x11.c | 10 ++ src/compositor.h | 3 +