Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-24 Thread Emilio Pozuelo Monfort
On 04/24/2013 02:02 PM, Richard Hughes wrote: > On 24 April 2013 12:42, Emilio Pozuelo Monfort wrote: >> This is exposed in the weston SDK (compositor.h is a public header). This >> patch >> breaks the ABI, but I don't think we have promised to keep it stable for now. > > I didn't know we offere

Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-24 Thread Richard Hughes
On 24 April 2013 12:42, Emilio Pozuelo Monfort wrote: > This is exposed in the weston SDK (compositor.h is a public header). This > patch > breaks the ABI, but I don't think we have promised to keep it stable for now. I didn't know we offered any king of ABI/API stability in Weston. If we do, we

Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-24 Thread Emilio Pozuelo Monfort
On 04/23/2013 05:37 PM, Rob Bradford wrote: > On Mon, Apr 22, 2013 at 12:57:03PM +0100, Richard Hughes wrote: >> --- >> src/compositor-drm.c | 1 + >> src/compositor.h | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/compositor-drm.c b/src/compositor-drm.c >> i

Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-24 Thread Rob Bradford
On Tue, Apr 23, 2013 at 08:32:28PM +0100, Richard Hughes wrote: > On 23 April 2013 16:37, Rob Bradford wrote: > > > Are you intending to expose this through the wayland protocol? If so > > have you considered how this ambiguity might be avoided. > > "serial_number"? Sounds good to me! Rob

Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-23 Thread Richard Hughes
On 23 April 2013 16:37, Rob Bradford wrote: > When I read the commit message I wondered "why does he need a serial" > for the wl_output. I was of course thinking about the wayland use of > "serial" as a sequence number. Ooops, my bad. > Are you intending to expose this through the wayland protoc

Re: [PATCH 2/3] Add a 'serial' property on weston_output

2013-04-23 Thread Rob Bradford
On Mon, Apr 22, 2013 at 12:57:03PM +0100, Richard Hughes wrote: > --- > src/compositor-drm.c | 1 + > src/compositor.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index 61ef97e..a454676 100644 > --- a/src/compositor-d

[PATCH 2/3] Add a 'serial' property on weston_output

2013-04-22 Thread Richard Hughes
--- src/compositor-drm.c | 1 + src/compositor.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 61ef97e..a454676 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1522,6 +1522,7 @@ create_output_for_connect

[PATCH 2/3] Add a 'serial' property on weston_output

2013-04-19 Thread Richard Hughes
--- src/compositor-drm.c | 1 + src/compositor.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compositor-drm.c b/src/compositor-drm.c index 61ef97e..a454676 100644 --- a/src/compositor-drm.c +++ b/src/compositor-drm.c @@ -1522,6 +1522,7 @@ create_output_for_connect