Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Kristian Høgsberg
On Tue, May 8, 2012 at 3:14 PM, Kristian Høgsberg wrote: > On Tue, May 8, 2012 at 12:26 PM, Daniel Stone wrote: >> Hi, >> >> On 7 May 2012 21:01, Kristian Høgsberg wrote: >>> On Tue, May 01, 2012 at 08:37:09PM +0100, Daniel Stone wrote: +     if (xkb_state_mod_name_is_active(xkb_state, "Mod

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Kristian Høgsberg
On Tue, May 8, 2012 at 12:26 PM, Daniel Stone wrote: > Hi, > > On 7 May 2012 21:01, Kristian Høgsberg wrote: >> On Tue, May 01, 2012 at 08:37:09PM +0100, Daniel Stone wrote: >>> +     if (xkb_state_mod_name_is_active(xkb_state, "Mod1", >>> +                                      (XKB_STATE_DEPRESS

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Daniel Stone
Hi, On 8 May 2012 18:09, Tiago Vignatti wrote: > On 05/08/2012 07:26 PM, Daniel Stone wrote: >> v2 coming soon I guess, sorry everyone who's been trying to compile >> Weston in the meantime. ;) I've pushed a for-weston branch of >> libxkbcommon which will still build with master. > > sorry, so wh

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Tiago Vignatti
On 05/08/2012 07:26 PM, Daniel Stone wrote: v2 coming soon I guess, sorry everyone who's been trying to compile Weston in the meantime. ;) I've pushed a for-weston branch of libxkbcommon which will still build with master. sorry, so what builds with libxkbcommon master now? Tiago

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Daniel Stone
Hi, On 8 May 2012 00:30, Bill Spitzak wrote: > Kristian Høgsberg wrote: >> The original code tests that shift and control are >> pressed, but it really should test modifers == SHIFT | CONTROL, that >> is, that those and *only* those modifiers are down. > > Watch out that this is only testing what

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-08 Thread Daniel Stone
Hi, On 7 May 2012 21:01, Kristian Høgsberg wrote: > On Tue, May 01, 2012 at 08:37:09PM +0100, Daniel Stone wrote: >> +     if (xkb_state_mod_name_is_active(xkb_state, "Mod1", >> +                                      (XKB_STATE_DEPRESSED | >> XKB_STATE_LATCHED))) >> +             modifiers |= MO

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-07 Thread Bill Spitzak
Kristian Høgsberg wrote: The original code tests that shift and control are pressed, but it really should test modifers == SHIFT | CONTROL, that is, that those and *only* those modifiers are down. Watch out that this is only testing what the user thinks of as modifiers. I did this and was bur

Re: [PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-07 Thread Kristian Høgsberg
On Tue, May 01, 2012 at 08:37:09PM +0100, Daniel Stone wrote: > Signed-off-by: Daniel Stone > --- > clients/eventdemo.c |5 ++- > clients/terminal.c | 33 ++ > clients/window.c| 96 > +++ > clients/window.h|9 ++

[PATCH 1/4] Port Wayland clients to new xkbcommon API

2012-05-01 Thread Daniel Stone
Signed-off-by: Daniel Stone --- clients/eventdemo.c |5 ++- clients/terminal.c | 33 ++ clients/window.c| 96 +++ clients/window.h|9 +++-- 4 files changed, 88 insertions(+), 55 deletions(-) diff --git a/clients