Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-07-22 Thread Pekka Paalanen
On Wed, 16 Jul 2014 11:27:06 +0200 Marek Chalupa wrote: > This function checks if a particular protocol error came in wire. > It's usefull in the cases where we hitherto used FAIL_TEST. > The problem with FAIL_TEST is that *any* assert will pass the test, > but we want only some asserts to pass t

[PATCH 1/3] tests: add expect_protocol_error function

2014-07-16 Thread Marek Chalupa
This function checks if a particular protocol error came in wire. It's usefull in the cases where we hitherto used FAIL_TEST. The problem with FAIL_TEST is that *any* assert will pass the test, but we want only some asserts to pass the test (i. e. we don't want the test to pass when it, for example

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-07-16 Thread Marek Chalupa
Hi, I fixed the comment as Bryce wrote (s/came/come) and fixed a white-space error. The logic of this version of the patch is equivalent to the old one. Thanks, Marek On 7 July 2014 20:41, Bryce W. Harrington wrote: > On Mon, Jul 07, 2014 at 05:47:41PM +0300, Pekka Paalanen wrote: > > On Thu,

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-07-07 Thread Bryce W. Harrington
On Mon, Jul 07, 2014 at 05:47:41PM +0300, Pekka Paalanen wrote: > On Thu, 19 Jun 2014 02:37:40 + > "Bryce W. Harrington" wrote: > > > On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > > > This function checks if a particular protocol error came in wire. > > > It's usefull in th

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-07-07 Thread Pekka Paalanen
On Thu, 19 Jun 2014 02:37:40 + "Bryce W. Harrington" wrote: > On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > > This function checks if a particular protocol error came in wire. > > It's usefull in the cases where we hitherto used FAIL_TEST. > > The problem with FAIL_TEST is

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-06-20 Thread Marek Chalupa
On 19 June 2014 04:37, Bryce W. Harrington wrote: > On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > > This function checks if a particular protocol error came in wire. > > It's usefull in the cases where we hitherto used FAIL_TEST. > > The problem with FAIL_TEST is that *any* ass

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-06-20 Thread Marek Chalupa
On 19 June 2014 04:37, Bryce W. Harrington wrote: > On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > > This function checks if a particular protocol error came in wire. > > It's usefull in the cases where we hitherto used FAIL_TEST. > > The problem with FAIL_TEST is that *any* ass

Re: [PATCH 1/3] tests: add expect_protocol_error function

2014-06-18 Thread Bryce W. Harrington
On Mon, May 26, 2014 at 04:58:05PM +0200, Marek Chalupa wrote: > This function checks if a particular protocol error came in wire. > It's usefull in the cases where we hitherto used FAIL_TEST. > The problem with FAIL_TEST is that *any* assert will pass the test, > but we want only some asserts to p

[PATCH 1/3] tests: add expect_protocol_error function

2014-05-26 Thread Marek Chalupa
This function checks if a particular protocol error came in wire. It's usefull in the cases where we hitherto used FAIL_TEST. The problem with FAIL_TEST is that *any* assert will pass the test, but we want only some asserts to pass the test (i. e. we don't want the test to pass when it, for example