Re: [PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-06 Thread Daniel Vetter
On Wed, Jun 05, 2013 at 12:03:37AM -0400, Kristian Høgsberg wrote: > On Tue, Jun 04, 2013 at 04:24:04PM +0300, Ander Conselvan de Oliveira wrote: > > From: Ander Conselvan de Oliveira > > > > This avoids one drmModeGetConnector() call every time the DPMS mode is > > set. That call can take hundre

Re: [PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-04 Thread Kristian Høgsberg
On Tue, Jun 04, 2013 at 04:24:04PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > This avoids one drmModeGetConnector() call every time the DPMS mode is > set. That call can take hundreds of milliseconds due to DDC. This looks good. As I replied to David, I th

Re: [PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-04 Thread Kristian Høgsberg
On Tue, Jun 04, 2013 at 06:31:26PM +0200, David Herrmann wrote: > Hi Ander > > On Tue, Jun 4, 2013 at 3:24 PM, Ander Conselvan de Oliveira > wrote: > > From: Ander Conselvan de Oliveira > > > > This avoids one drmModeGetConnector() call every time the DPMS mode is > > set. That call can take hun

Re: [PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-04 Thread David Herrmann
Hi Ander On Tue, Jun 4, 2013 at 3:24 PM, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > This avoids one drmModeGetConnector() call every time the DPMS mode is > set. That call can take hundreds of milliseconds due to DDC. > --- > src/compositor-drm.c | 21 +++--

Re: [PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-04 Thread Rob Bradford
On Tue, Jun 04, 2013 at 04:24:04PM +0300, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > This avoids one drmModeGetConnector() call every time the DPMS mode is > set. That call can take hundreds of milliseconds due to DDC. > --- > src/compositor-drm.c | 21 +++--

[PATCH 1/2] compositor-drm: Cache the DPMS property on drm_output

2013-06-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This avoids one drmModeGetConnector() call every time the DPMS mode is set. That call can take hundreds of milliseconds due to DDC. --- src/compositor-drm.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/composit