Re: [PATCH 1/2] Don't send modifier events to toytoolkit clients.

2012-03-04 Thread Scott Moreau
> > Hi Scott, > > to me the commit message seems wrong compared to the change. When > you talk about sending and clients, and do not prefix the title > with window, I assume you are patching the server to not > send events to clients. > > If I understood right, this patch would be better described

Re: [PATCH 1/2] Don't send modifier events to toytoolkit clients.

2012-03-04 Thread Pekka Paalanen
On Sat, 3 Mar 2012 08:48:29 -0700 Scott Moreau wrote: > Clients shouldn't attempt to track modifier state independently > since it's already tracked in the modifier mask. Hi Scott, to me the commit message seems wrong compared to the change. When you talk about sending and clients, and do not

Re: [PATCH 1/2] Don't send modifier events to toytoolkit clients.

2012-03-03 Thread Scott Moreau
It is my understanding that games wanting uninhibited input events will end up reading raw input data directly. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH 1/2] Don't send modifier events to toytoolkit clients.

2012-03-03 Thread Daniel Stone
Hi, On 3 March 2012 15:48, Scott Moreau wrote: > Clients shouldn't attempt to track modifier state independently > since it's already tracked in the modifier mask. NAK - games want to use Ctrl/Alt to shoot, and so on. But they're right that they shouldn't try to independently track the state.

[PATCH 1/2] Don't send modifier events to toytoolkit clients.

2012-03-03 Thread Scott Moreau
Clients shouldn't attempt to track modifier state independently since it's already tracked in the modifier mask. --- clients/window.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/clients/window.c b/clients/window.c index e917ce6..538571e 100644 --- a/clients/window.c +